Closed Bug 796006 Opened 11 years ago Closed 11 years ago

[markup panel] Don't fully expand nodes with large amounts of children in markup panel (performance)

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 20

People

(Reporter: harth, Assigned: dcamp)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

fixed tests
25.38 KB, patch
Details | Diff | Splinter Review 
Try inspecting a page with a ton of nodes, like http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js, where span#the-code has a bunch of children.

We should just show the first fifty or so of the children, with a link to show more at the end.
I run into this issue very often.
Priority: -- → P2
Summary: Don't fully expand nodes with large amounts of children in markup panel → [markup panel] Don't fully expand nodes with large amounts of children in markup panel (performance)
In the future DevTools toobox, the markup view won't be toggable anymore, and will be shown as soon as the inspector is started. This makes this bug a blocker.
Priority: P2 → P1
Assignee: nobody → paul
Assignee: paul → nobody
Dave, iirc, you had a plan for that.
Assignee: nobody → dcamp
Any update on this?
Working on it.
Blocks: 788977
Blocks: 816946
https://github.com/campd/mozilla-central/commits/markup-limits has my current work.  Needs some tests and a real patch.
No longer blocks: 788977
I added tests to that branch, should have a patch up today.
(In reply to Dave Camp (:dcamp) from comment #8)
> https://github.com/joewalker/devtools-window/pull/323

Is it ready for a review?
(In reply to Paul Rouget [:paul] from comment #9)
> (In reply to Dave Camp (:dcamp) from comment #8)
> > https://github.com/joewalker/devtools-window/pull/323
> 
> Is it ready for a review?

Yeah - I was going to ping Joe for it (since he reviewed MarkupView to begin with) but feel free to chime in.
I would like to land that today. Dave, I think you got a r+ from Joe (github). Can you update and attach a patch here?
Attached patch fix (obsolete) — — Splinter Review 
As reviewed in the pull request, plus fixes.
Attachment #693694 - Flags: review?(jwalker)
Attachment #693694 - Flags: review?(jwalker) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/6b168eb45722
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Test was bit-rotted by the API patch.

Fixed and re-landed as https://hg.mozilla.org/integration/fx-team/rev/538602f4cb51
Backed out again (orange): https://hg.mozilla.org/integration/fx-team/rev/dfd316f5c81d
Whiteboard: [fixed-in-fx-team]
Attached patch fixed tests — — Splinter Review 
One more try...
Attachment #693694 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/538602f4cb51
https://hg.mozilla.org/mozilla-central/rev/dfd316f5c81d
https://hg.mozilla.org/mozilla-central/rev/4d709ea729b3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Whiteboard: [fixed-in-fx-team]
Hi.
As I said in the mailing list[1], I found that the "Shaw all %S nodes" isn't marked as a plural, and that makes the translations look really bad.
Can someone solve it?

[1] https://groups.google.com/forum/#!topic/mozilla.dev.l10n/Lt437W2D8ag
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.