[markup panel] Don't fully expand nodes with large amounts of children in markup panel (performance)

RESOLVED FIXED in Firefox 20

Status

P1
normal
RESOLVED FIXED
7 years ago
8 months ago

People

(Reporter: harth, Assigned: dcamp)

Tracking

unspecified
Firefox 20

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Try inspecting a page with a ton of nodes, like http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js, where span#the-code has a bunch of children.

We should just show the first fifty or so of the children, with a link to show more at the end.
I run into this issue very often.
Priority: -- → P2
Summary: Don't fully expand nodes with large amounts of children in markup panel → [markup panel] Don't fully expand nodes with large amounts of children in markup panel (performance)
In the future DevTools toobox, the markup view won't be toggable anymore, and will be shown as soon as the inspector is started. This makes this bug a blocker.
Priority: P2 → P1

Updated

6 years ago
Assignee: nobody → paul

Updated

6 years ago
Assignee: paul → nobody
Dave, iirc, you had a plan for that.
(Assignee)

Updated

6 years ago
Assignee: nobody → dcamp
Any update on this?
(Assignee)

Comment 5

6 years ago
Working on it.

Updated

6 years ago
Blocks: 788977

Updated

6 years ago
Blocks: 816946
(Assignee)

Comment 6

6 years ago
https://github.com/campd/mozilla-central/commits/markup-limits has my current work.  Needs some tests and a real patch.

Updated

6 years ago
No longer blocks: 788977
(Assignee)

Comment 7

6 years ago
I added tests to that branch, should have a patch up today.
(In reply to Dave Camp (:dcamp) from comment #8)
> https://github.com/joewalker/devtools-window/pull/323

Is it ready for a review?
(Assignee)

Comment 10

6 years ago
(In reply to Paul Rouget [:paul] from comment #9)
> (In reply to Dave Camp (:dcamp) from comment #8)
> > https://github.com/joewalker/devtools-window/pull/323
> 
> Is it ready for a review?

Yeah - I was going to ping Joe for it (since he reviewed MarkupView to begin with) but feel free to chime in.
I would like to land that today. Dave, I think you got a r+ from Joe (github). Can you update and attach a patch here?
(Assignee)

Comment 12

6 years ago
Created attachment 693694 [details] [diff] [review]
fix

As reviewed in the pull request, plus fixes.
Attachment #693694 - Flags: review?(jwalker)
Attachment #693694 - Flags: review?(jwalker) → review+

Updated

6 years ago
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/6b168eb45722
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
(Assignee)

Comment 15

6 years ago
Test was bit-rotted by the API patch.

Fixed and re-landed as https://hg.mozilla.org/integration/fx-team/rev/538602f4cb51
Backed out again (orange): https://hg.mozilla.org/integration/fx-team/rev/dfd316f5c81d
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 17

6 years ago
Created attachment 694580 [details] [diff] [review]
fixed tests

One more try...
Attachment #693694 - Attachment is obsolete: true
(Assignee)

Comment 18

6 years ago
https://hg.mozilla.org/integration/fx-team/rev/4d709ea729b3
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/538602f4cb51
https://hg.mozilla.org/mozilla-central/rev/dfd316f5c81d
https://hg.mozilla.org/mozilla-central/rev/4d709ea729b3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Whiteboard: [fixed-in-fx-team]

Comment 20

3 years ago
Hi.
As I said in the mailing list[1], I found that the "Shaw all %S nodes" isn't marked as a plural, and that makes the translations look really bad.
Can someone solve it?

[1] https://groups.google.com/forum/#!topic/mozilla.dev.l10n/Lt437W2D8ag

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.