796006 - [markup panel] Don't fully expand nodes with large amounts of children in markup panel (performance)

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Heather Arthur [:harth]]

Try inspecting a page with a ton of nodes, like http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js, where span#the-code has a bunch of children.

We should just show the first fifty or so of the children, with a link to show more at the end.

Comment 1

[Paul Rouget [:paul]]

I run into this issue very often.

Comment 2

[Paul Rouget [:paul]]

In the future DevTools toobox, the markup view won't be toggable anymore, and will be shown as soon as the inspector is started. This makes this bug a blocker.

Comment 3

[Paul Rouget [:paul]]

Dave, iirc, you had a plan for that.

Comment 4

[Paul Rouget [:paul]]

Any update on this?

Comment 5

[Dave Camp (:dcamp)]

Working on it.

Comment 6

[Dave Camp (:dcamp)]

https://github.com/campd/mozilla-central/commits/markup-limits has my current work.  Needs some tests and a real patch.

Comment 7

[Dave Camp (:dcamp)]

I added tests to that branch, should have a patch up today.

Comment 8

[Dave Camp (:dcamp)]

https://github.com/joewalker/devtools-window/pull/323

Comment 9

[Paul Rouget [:paul]]

(In reply to Dave Camp (:dcamp) from comment #8)
> https://github.com/joewalker/devtools-window/pull/323

Is it ready for a review?

Comment 10

[Dave Camp (:dcamp)]

(In reply to Paul Rouget [:paul] from comment #9)
> (In reply to Dave Camp (:dcamp) from comment #8)
> > https://github.com/joewalker/devtools-window/pull/323
> 
> Is it ready for a review?

Yeah - I was going to ping Joe for it (since he reviewed MarkupView to begin with) but feel free to chime in.

Comment 11

[Paul Rouget [:paul]]

I would like to land that today. Dave, I think you got a r+ from Joe (github). Can you update and attach a patch here?

Comment 12

[Dave Camp (:dcamp)]

Attachment: fix

As reviewed in the pull request, plus fixes.

Comment 13

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/6b168eb45722

Comment 14

[Paul Rouget [:paul]]

Backed out (orange): https://hg.mozilla.org/integration/fx-team/rev/6ee0e3a037e4

Comment 15

[Dave Camp (:dcamp)]

Test was bit-rotted by the API patch.

Fixed and re-landed as https://hg.mozilla.org/integration/fx-team/rev/538602f4cb51

Comment 16

[Paul Rouget [:paul]]

Backed out again (orange): https://hg.mozilla.org/integration/fx-team/rev/dfd316f5c81d

Comment 17

[Dave Camp (:dcamp)]

Attachment: fixed tests

One more try...

Comment 18

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/4d709ea729b3

Comment 19

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/538602f4cb51
https://hg.mozilla.org/mozilla-central/rev/dfd316f5c81d
https://hg.mozilla.org/mozilla-central/rev/4d709ea729b3

Comment 20

[Safa Alfulaij]

Hi.
As I said in the mailing list[1], I found that the "Shaw all %S nodes" isn't marked as a plural, and that makes the translations look really bad.
Can someone solve it?

[1] https://groups.google.com/forum/#!topic/mozilla.dev.l10n/Lt437W2D8ag