796044 - Firefox should get pinned to the OS taskbar after installation independent of default browser in Win8

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect)

Description

[juan becerra [:juanb]]

When you install Firefox on Windows 8, the program does not get pinned to the taskbar after installation if you dismiss or say No to the default browser prompt. If you make it your default then it gets pinned.

Steps:
1. Install Firefox
2. When the program launches click on No or dismiss the default browser prompt.
3. Close the browser.

Expected: According to https://bugzilla.mozilla.org/show_bug.cgi?id=791019#c51 the browser icon should be pinned in the taskbar after installtion.

Actual: The browser icon disappears from the taskbar.

You can keep the icon if you context click on it while the program is running (even if you haven't select Firefox as your default browser).

The browser icon is also pinned by default if you click on Yes on the default browser prompt when you install it.

Comment 1

[Brian R. Bondy [:bbondy]]

Jim could you take a look at this one? (I have another coming that is higher priority than this one)

Comment 2

[Jim Mathies [:jimm]]

This is the default behavior we currently have. We don't opin unless we're the default, and since the install doesn't set the default anymore, we don't pin initially. We do pin when the user explicitly sets us as the default through the default browser check. 

We could change this such that we always pin on initial install.

Comment 3

[Brian R. Bondy [:bbondy]]

I think making it independent of default would be good.  Probably for all platforms, but if not at least on win8.

Comment 4

[Brian R. Bondy [:bbondy]]

I'll take this back when I get a chance to free you up for more important metro work.  Thanks for the preliminary investigations in Comment 2.

Comment 5

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

If r+ed, after the merge I'll request this for v17 beta and v18 aurora

Comment 6

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3113b696455b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3113b696455b

Comment 8

[Brian R. Bondy [:bbondy]]

Comment on attachment 668846 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Windows 8 handling its own defaults
User impact if declined:  Installations will not pin an icon to the taskbar.  This pinning probably leads to more browser usage so I think we should get this in.
Testing completed (on m-c, etc.): I tested this on my win8 machine from m-c and it pinned the icon. 
Risk to taking this patch (and alternatives if risky): Very low
String or UUID changes made by this patch: None

Comment 9

[Brian R. Bondy [:bbondy]]

Marking qawanted just to test on a fresh win8.  Win8 does a lot of strange caching and remembering of settings so I want to make sure my testing on win8 was OK.

Note to release drivers: I see no harm in getting this on beta and aurora in the meantime though.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 668846 [details] [diff] [review]
Patch v1

Let's get this uplifted and make sure QA verifies before Beta 4 in case there is any unexpected behaviour requiring a backout.

Comment 11

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/releases/mozilla-beta/rev/15cfd3e488f4
https://hg.mozilla.org/releases/mozilla-aurora/rev/81335e8960fa

Comment 12

[u279076]

Swapping qawanted for verifyme to ensure this gets verified.

Comment 13

[Manuela Muntean [Away]]

Verified on FF17b3, Mozilla/5.0 (Windows NT 6.2; rv:17.0) Gecko/17.0 Firefox/17.0, Build ID: 20121023124120

Comment 14

[Manuela Muntean [Away]]

Verified on Firefox 18 beta 2, User Agent: Mozilla/5.0 (Windows NT 6.2; rv:18.0) Gecko/20100101 Firefox/18.0, Build ID: 20121128060531

Comment 15

[Manuela Muntean [Away]]

Verified fixed on Firefox 19 beta 2.

User Agent: Mozilla/5.0 (Windows NT 6.2; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130116072953