79608 - Embedding API: get/set charset

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[kill this account]

embedded gecko needs an API to get/set the charset

Comment 1

[Andreas Becker]

Changing QA contact to teruko.

Comment 2

[kill this account]

Attachment: patch adding nsIDocCharset

Comment 3

[kill this account]

ftang: I checked this with vidur. Would you review this?

Comment 4

[kill this account]

Attachment: updated patch (fix bit rot)

Comment 5

[Frank Tang]

do we also need to change
/xpfe/browser/resources/content/fastnav.js, line 792 -- 
getBrowser().documentCharsetInfo.forcedCharset = characterSet;
?

Comment 6

[Frank Tang]

please ask vidur to review.

Comment 7

[kill this account]

Attachment: same content as the previous patch but hopefully it will work more smoothly with the patch command

Comment 8

[Frank Tang]

1. the following should be changed
RCS file: /cvsroot/mozilla/intl/chardet/public/MANIFEST_IDL,v

+nsIDOcCharset.idl

should be

+nsIDocCharset.idl
2. we need to add nsIDocCharset.idl into mozilla/intl/chardet/macbuild/
chardetIDL.mcp after we check in nsIDOcCharset.idl and before we land other 
stuff. 

I verify on both mac and window, it build and run without problem. 

Comment 9

[Frank Tang]

r=ftang

Comment 10

[kill this account]

a couple of notes:

the diff of Makefile.in and makefile.win have a line continuator '\' 
which makes patch cranky.

the DomWindow GI function may collide with the DomWindow GI patch
in http://bugzilla.mozilla.org/show_bug.cgi?id=75538 . I will merge
as necessary.

Comment 11

[Phil Peterson]

TM to 0.9.2 per PDT triage (it's OK to check it in by Friday or after 0.9.2 branch).

Comment 12

[vidur (gone)]

sr=vidur for the patch.

We need to create an inventory of interfaces that should be GIable from
nsIDOMWindow. I'm almost tempted to have nsGlobalWindow::GI called
nsDocShell::GI...or would that be too evil?

Comment 13

[kill this account]

what about adding nsGlobalWindowto BoxObject?

Comment 14

[kill this account]

code checkin in last night

Comment 15

[Teruko Kobayashi]

Brian, please put more information QA can verify this.

Comment 16

[Teruko Kobayashi]

nsIDocCharset is there.

Comment 17

[Jerry]

http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/charsetOverl
ay.js#18

BrowserSetDefaultCharacterSet() is currently do nothing.
why MultiplexHandler still call SetDefaultCharacterSet()?

Comment 18

[kill this account]

> BrowserSetDefaultCharacterSet() is currently do nothing.

As I understand it that call is no longer used.

> why MultiplexHandler still call SetDefaultCharacterSet()?

To set the fallback character set.

Comment 19

[Jerry]

brian, you can see that:

 58 function SetDefaultCharacterSet(charset)
 59 {
 60     dump("Charset Overlay menu item pressed: " + charset + "\n");
 61     BrowserSetDefaultCharacterSet(charset);
 62 }

since  BrowserSetDefaultCharacterSet(charset) do nothing, 
SetDefaultCharacterSet do nothing meanful.

So I think MultiplexHandler can remove SetDefaultCharacterSet .

Comment 20

[kill this account]

yes, it looks like the javascript one does not do anything but the C++ one
does:
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsDocumentViewer.cpp#68
64

If you would like to remove this might I suggest you open a new bug.