Closed Bug 79608 Opened 19 years ago Closed 19 years ago

Embedding API: get/set charset

Categories

(Core :: Internationalization, defect)

x86
All
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: bstell, Assigned: bstell)

References

Details

Attachments

(3 files)

embedded gecko needs an API to get/set the charset
Blocks: 65898
Changing QA contact to teruko.
QA Contact: andreasb → teruko
ftang: I checked this with vidur. Would you review this?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Whiteboard: patch waiting on platform buddy review
do we also need to change
/xpfe/browser/resources/content/fastnav.js, line 792 -- 
getBrowser().documentCharsetInfo.forcedCharset = characterSet;
?
please ask vidur to review.
1. the following should be changed
RCS file: /cvsroot/mozilla/intl/chardet/public/MANIFEST_IDL,v

+nsIDOcCharset.idl

should be

+nsIDocCharset.idl
2. we need to add nsIDocCharset.idl into mozilla/intl/chardet/macbuild/
chardetIDL.mcp after we check in nsIDOcCharset.idl and before we land other 
stuff. 

I verify on both mac and window, it build and run without problem. 
r=ftang
a couple of notes:

the diff of Makefile.in and makefile.win have a line continuator '\' 
which makes patch cranky.

the DomWindow GI function may collide with the DomWindow GI patch
in http://bugzilla.mozilla.org/show_bug.cgi?id=75538 . I will merge
as necessary.

Whiteboard: patch waiting on platform buddy review → patch waiting on super review 05/16/ 17:06
TM to 0.9.2 per PDT triage (it's OK to check it in by Friday or after 0.9.2 branch).
Target Milestone: mozilla0.9.1 → mozilla0.9.2
sr=vidur for the patch.

We need to create an inventory of interfaces that should be GIable from
nsIDOMWindow. I'm almost tempted to have nsGlobalWindow::GI called
nsDocShell::GI...or would that be too evil?
what about adding nsGlobalWindowto BoxObject?
code checkin in last night
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: patch waiting on super review 05/16/ 17:06
Brian, please put more information QA can verify this.
nsIDocCharset is there.
Status: RESOLVED → VERIFIED
http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/charsetOverl
ay.js#18

BrowserSetDefaultCharacterSet() is currently do nothing.
why MultiplexHandler still call SetDefaultCharacterSet()?

> BrowserSetDefaultCharacterSet() is currently do nothing.

As I understand it that call is no longer used.

> why MultiplexHandler still call SetDefaultCharacterSet()?

To set the fallback character set.

brian, you can see that:

 58 function SetDefaultCharacterSet(charset)
 59 {
 60     dump("Charset Overlay menu item pressed: " + charset + "\n");
 61     BrowserSetDefaultCharacterSet(charset);
 62 }

since  BrowserSetDefaultCharacterSet(charset) do nothing, 
SetDefaultCharacterSet do nothing meanful.

So I think MultiplexHandler can remove SetDefaultCharacterSet .
yes, it looks like the javascript one does not do anything but the C++ one
does:
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsDocumentViewer.cpp#68
64

If you would like to remove this might I suggest you open a new bug.
You need to log in before you can comment on or make changes to this bug.