Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
Firefox 18
x86
macOS
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Assignee

Description

7 years ago
Catch all bugs for trivial code clean up.
Assignee

Comment 1

7 years ago
Attachment #666655 - Flags: review?(blassey.bugs)
Assignee

Comment 2

7 years ago
Attachment #666661 - Flags: review?(blassey.bugs)
Attachment #666655 - Flags: review?(blassey.bugs) → review+
Attachment #666661 - Flags: review?(blassey.bugs) → review+
Comment on attachment 666661 [details] [diff] [review]
s/MOZ_JAVA_COMPOSITOR/MOZ_ANDROID_OMTC/g

Review of attachment 666661 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5039,5 @@
>  fi
>  
>  
>  dnl ========================================================
>  dnl = Build with the Android Java compositor

Drive-by - shouldn't this comment also be changed?

::: gfx/layers/opengl/LayerManagerOGL.cpp
@@ +920,5 @@
>    }
>  
>    mGLContext->fEnable(LOCAL_GL_SCISSOR_TEST);
>  
>    // If the Java compositor is being used, this clear will be done in

Same here.
Assignee

Comment 5

7 years ago
Argg, a configure change :(

Alright patch coming.
Assignee

Comment 6

7 years ago
Posted patch follow up (obsolete) — Splinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #666971 - Flags: review?(chrislord.net)
Comment on attachment 666971 [details] [diff] [review]
follow up

Review of attachment 666971 [details] [diff] [review]:
-----------------------------------------------------------------

Is this the right patch? If so, I don't think I'm the right reviewer for this.
Assignee

Comment 8

7 years ago
Posted patch follow upSplinter Review
right patch
Attachment #666971 - Attachment is obsolete: true
Attachment #666971 - Flags: review?(chrislord.net)
Attachment #666986 - Flags: review?(chrislord.net)
Comment on attachment 666986 [details] [diff] [review]
follow up

Review of attachment 666986 [details] [diff] [review]:
-----------------------------------------------------------------

Better :)
Attachment #666986 - Flags: review?(chrislord.net) → review+
Assignee

Comment 11

7 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5dabf022b7
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/5a5dabf022b7
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.