796084 - Clean up PZC code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Benoit Girard (:BenWa)]

Catch all bugs for trivial code clean up.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: mCheckerboardLayer -> mScreenshotLayer

Comment 2

[Benoit Girard (:BenWa)]

Attachment: s/MOZ_JAVA_COMPOSITOR/MOZ_ANDROID_OMTC/g

Comment 3

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d9f6bb75bb0
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b0fd0ddbfec

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 666661 [details] [diff] [review]
s/MOZ_JAVA_COMPOSITOR/MOZ_ANDROID_OMTC/g

Review of attachment 666661 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5039,5 @@
>  fi
>  
>  
>  dnl ========================================================
>  dnl = Build with the Android Java compositor

Drive-by - shouldn't this comment also be changed?

::: gfx/layers/opengl/LayerManagerOGL.cpp
@@ +920,5 @@
>    }
>  
>    mGLContext->fEnable(LOCAL_GL_SCISSOR_TEST);
>  
>    // If the Java compositor is being used, this clear will be done in

Same here.

Comment 5

[Benoit Girard (:BenWa)]

Argg, a configure change :(

Alright patch coming.

Comment 6

[Benoit Girard (:BenWa)]

Attachment: follow up

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 666971 [details] [diff] [review]
follow up

Review of attachment 666971 [details] [diff] [review]:
-----------------------------------------------------------------

Is this the right patch? If so, I don't think I'm the right reviewer for this.

Comment 8

[Benoit Girard (:BenWa)]

Attachment: follow up

right patch

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 666986 [details] [diff] [review]
follow up

Review of attachment 666986 [details] [diff] [review]:
-----------------------------------------------------------------

Better :)

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3d9f6bb75bb0
https://hg.mozilla.org/mozilla-central/rev/1b0fd0ddbfec

Comment 11

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5dabf022b7

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a5dabf022b7