Closed Bug 796084 Opened 8 years ago Closed 8 years ago

Clean up PZC code

Categories

(Firefox for Android :: Toolbar, defect)

Product:
Firefox for Android
Component:
Toolbar
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 18

People

(Reporter: BenWa, Assigned: BenWa)

Details

Attachments

(3 files, 1 obsolete file)

mCheckerboardLayer -> mScreenshotLayer
5.34 KB, patch
blassey
: review+
Details | Diff | Splinter Review
s/MOZ_JAVA_COMPOSITOR/MOZ_ANDROID_OMTC/g
25.05 KB, patch
blassey
: review+
Details | Diff | Splinter Review
follow up
1.90 KB, patch
cwiiis
: review+
Details | Diff | Splinter Review 
Catch all bugs for trivial code clean up.
Attachment #666655 - Flags: review?(blassey.bugs)
Attachment #666661 - Flags: review?(blassey.bugs)
Attachment #666655 - Flags: review?(blassey.bugs) → review+
Attachment #666661 - Flags: review?(blassey.bugs) → review+
Comment on attachment 666661 [details] [diff] [review]
s/MOZ_JAVA_COMPOSITOR/MOZ_ANDROID_OMTC/g

Review of attachment 666661 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5039,5 @@
>  fi
>  
>  
>  dnl ========================================================
>  dnl = Build with the Android Java compositor

Drive-by - shouldn't this comment also be changed?

::: gfx/layers/opengl/LayerManagerOGL.cpp
@@ +920,5 @@
>    }
>  
>    mGLContext->fEnable(LOCAL_GL_SCISSOR_TEST);
>  
>    // If the Java compositor is being used, this clear will be done in

Same here.
Argg, a configure change :(

Alright patch coming.
Attached patch follow up (obsolete) — — Splinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #666971 - Flags: review?(chrislord.net)
Comment on attachment 666971 [details] [diff] [review]
follow up

Review of attachment 666971 [details] [diff] [review]:
-----------------------------------------------------------------

Is this the right patch? If so, I don't think I'm the right reviewer for this.
Attached patch follow up — — Splinter Review 
right patch
Attachment #666971 - Attachment is obsolete: true
Attachment #666971 - Flags: review?(chrislord.net)
Attachment #666986 - Flags: review?(chrislord.net)
Comment on attachment 666986 [details] [diff] [review]
follow up

Review of attachment 666986 [details] [diff] [review]:
-----------------------------------------------------------------

Better :)
Attachment #666986 - Flags: review?(chrislord.net) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5dabf022b7
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/5a5dabf022b7
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.