796116 - installPackage broken by changeset c09a0c022b2e

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[David Chan [:dchan]]

It appears that changeset c09a0c022b2e inadvertently broke installPackage

Bug 789527
https://hg.mozilla.org/mozilla-central/rev/eda2891c545b

changed how package installs were handle.
1 - installPackage was renamed downloadPackage
2 - case "Webapps:InstallPackage":
was also changed to notifyObservers about "webapps-ask-install"

The PGO merge from m-i undid the latter change resulting in a reference to an undefined function
http://hg.mozilla.org/mozilla-central/rev/c09a0c022b2e

Comment 1

[Phil Ringnalda (:philor)]

Given my demonstrated inability to correctly merge it with http://hg.mozilla.org/mozilla-central/rev/cdd4506bc66c (silly me, I thought since no tests failed, I'd done it right), I don't think you want me to fix it, but I can vow not to do it again, by just backing out whatever bent lands directly on m-c instead :)

Comment 2

[David Chan [:dchan]]

No worries, there are no tests that test installPackage afaik. I believe the fix is a one line change to Webapps:InstallPackage

Comment 3

[David Chan [:dchan]]

Attachment: add back in notifyObserver

This should be all that is needed. :bent's patch didn't touch any other overlapping areas from what I saw

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 666771 [details] [diff] [review]
add back in notifyObserver

thanks David!

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa6148b9c877

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fa6148b9c877

Comment 7

[Andrew Overholt [:overholt]]

Fabrice says we shouldn't block on this as it sounds like it was user error.