Closed Bug 796116 Opened 7 years ago Closed 7 years ago
Package broken by changeset c09a0c022b2e
It appears that changeset c09a0c022b2e inadvertently broke installPackage Bug 789527 https://hg.mozilla.org/mozilla-central/rev/eda2891c545b changed how package installs were handle. 1 - installPackage was renamed downloadPackage 2 - case "Webapps:InstallPackage": was also changed to notifyObservers about "webapps-ask-install" The PGO merge from m-i undid the latter change resulting in a reference to an undefined function http://hg.mozilla.org/mozilla-central/rev/c09a0c022b2e
Given my demonstrated inability to correctly merge it with http://hg.mozilla.org/mozilla-central/rev/cdd4506bc66c (silly me, I thought since no tests failed, I'd done it right), I don't think you want me to fix it, but I can vow not to do it again, by just backing out whatever bent lands directly on m-c instead :)
No worries, there are no tests that test installPackage afaik. I believe the fix is a one line change to Webapps:InstallPackage
Assignee: nobody → dchan+bugzilla
This should be all that is needed. :bent's patch didn't touch any other overlapping areas from what I saw
Attachment #666771 - Flags: review?(fabrice)
Comment on attachment 666771 [details] [diff] [review] add back in notifyObserver thanks David!
Attachment #666771 - Flags: review?(fabrice) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Fabrice says we shouldn't block on this as it sounds like it was user error.
blocking-basecamp: ? → -
You need to log in before you can comment on or make changes to this bug.