Closed
Bug 796217
Opened 9 years ago
Closed 9 years ago
Refactor Webapps.jsm and related files
Categories
(Core Graveyard :: DOM: Apps, defect)
Tracking
(firefox18 fixed)
RESOLVED
FIXED
mozilla18
Tracking | Status | |
---|---|---|
firefox18 | --- | fixed |
People
(Reporter: fabrice, Assigned: fabrice)
Details
Attachments
(2 files, 2 obsolete files)
26.79 KB,
patch
|
gwagner
:
review+
|
Details | Diff | Splinter Review |
19.78 KB,
patch
|
ddahl
:
review+
|
Details | Diff | Splinter Review |
Webapps.jsm has grown a bit too much... Let's trim down some fat.
Assignee | ||
Comment 1•9 years ago
|
||
In this part, we move the DOMApplicationManifest into AppsUtils.jsm and rename it ManifestHelper.
Assignee | ||
Comment 2•9 years ago
|
||
Renaming PermissionTable.jsm to PermissionsManager.jsm and exporting just what we need in Webapps.jsm which is the only user so far. Try run at https://tbpl.mozilla.org/?tree=Try&rev=7a90d8c8c23e with both parts.
Assignee | ||
Updated•9 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Assignee | ||
Comment 3•9 years ago
|
||
Fixed a bug in the way we call uninstall() from installPermissions. New try run at https://tbpl.mozilla.org/?tree=Try&rev=e2e5a37830ab
Attachment #666780 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
Passes tests locally, I made a new push to try to be sure: https://tbpl.mozilla.org/?tree=Try&rev=9bdd0f3bfa2c
Attachment #666788 -
Attachment is obsolete: true
Attachment #667091 -
Flags: review?(ddahl)
Assignee | ||
Updated•9 years ago
|
Attachment #666777 -
Flags: review?(anygregor)
Comment 5•9 years ago
|
||
Comment on attachment 667091 [details] [diff] [review] Part 2: refactor PermissionTable.jsm Review of attachment 667091 [details] [diff] [review]: ----------------------------------------------------------------- The only thing I would caution against is calling the exported object "PermissionsManager", I think there will be some confusion with nsIPermsisionManager. I would name the jsm and the exported object "PermissionsInstaller" for clarity.
Attachment #667091 -
Flags: review?(ddahl) → review+
Updated•9 years ago
|
Attachment #666777 -
Flags: review?(anygregor) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cc0da49ccb5 https://hg.mozilla.org/integration/mozilla-inbound/rev/eb6641924764
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2cc0da49ccb5 https://hg.mozilla.org/mozilla-central/rev/eb6641924764
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•9 years ago
|
status-firefox18:
--- → fixed
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•