796269 - [settings] set time manually once, cannot do again

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[GH to BZ]

[GitHub issue by autonome on 2012-09-29T23:51:11Z, https://github.com/mozilla-b2g/gaia/issues/5522]
STR:

1. go to Date & Time
2. turn off set automatically
3. change the time
4. click OK
5. try to change the time again

Cannot - picker doesn't open.

Workaround - toggle set automatically again

Comment 1

[GH to BZ]

[GitHub comment by autonome on 2012-09-29T23:52:59Z]
/cc @ian-liu

Comment 2

[Alex Keybl [:akeybl]]

[mass adding reproducible keyword for any open Gaia bug with the word "STR:" in comments]

Comment 3

[Dietrich Ayala (:dietrich)]

still reproducible, and will both date and time. i have to hit a bunch of times before it opens the pickers.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Taking a look at this.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5721

Pointer to Github pull-request

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Attachment: part 2 - track the "keyboard" as closed when a form element becomes unfocused

The problem here seems to be that the FormAssistant doesn't know that the "keyboard" (date/time picker) has been closed. So it won't open another one unless you somehow manage to focus another element that resets this status.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/61e0ba0e9165

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://github.com/mozilla-b2g/gaia/commit/340465435df23f556bcb24b18e0fddba85809474

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/61e0ba0e9165

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/153f9364f85b

Comment 11

[John Hammink]

Otoro daily: 10-11-2012
* gaia: 2667536e3b06e46dd193aa6d76ba08dad2d867be
* gonk: 6ec34aa3d66331054de37eabc594ad923654b27c

Still busted.  Picker doesn't open.   Reopening.

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

Works for me on my dev build. Does gonk somehow need to be updated for the daily builds? Is this automatically pulled from Aurora now?

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

According to Ian, the fix doesn't really fix what described in STR, but rather Keyboard API feature planned in bug 793108 can.

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

Still fixed for me. By whatever patch.

Comment 15

[Rebecca Billings [:rbillings]]

Verified on the 10/22 build that user can set & re-set the time without issue.