796300 - [b2g-bluetooth] Set audio device BLUETOOTH_SCO_HEADSET to unavailable when disconnect Sco socket

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v1 patch

set device connection state to available when open a SCO socket; set state to unavailable when close the SCO socket.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 666853 [details] [diff] [review]
v1 patch

Review of attachment 666853 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with fixes

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +83,5 @@
>  CloseScoSocket()
>  {
>    MOZ_ASSERT(NS_IsMainThread());
>  
> +  nsCOMPtr<nsIAudioManager> am = do_GetService("@mozilla.org/telephony/audiomanager;1");

We should check validity of the service.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final version, r=qdot

try server: https://tbpl.mozilla.org/?tree=Try&rev=93d987c3a6c8

Comment 4

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2756948142d

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a2756948142d