Closed Bug 796300 Opened 7 years ago Closed 7 years ago

[b2g-bluetooth] Set audio device BLUETOOTH_SCO_HEADSET to unavailable when disconnect Sco socket

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: gyeh, Assigned: gyeh)

Details

(Whiteboard: [LOE:S])

Attachments

(1 file, 1 obsolete file)

No description provided.
blocking-basecamp: + → ?
Attached patch v1 patch (obsolete) — Splinter Review
set device connection state to available when open a SCO socket; set state to unavailable when close the SCO socket.
Attachment #666853 - Flags: review?(kyle)
Comment on attachment 666853 [details] [diff] [review]
v1 patch

Review of attachment 666853 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with fixes

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +83,5 @@
>  CloseScoSocket()
>  {
>    MOZ_ASSERT(NS_IsMainThread());
>  
> +  nsCOMPtr<nsIAudioManager> am = do_GetService("@mozilla.org/telephony/audiomanager;1");

We should check validity of the service.
Attachment #666853 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/a2756948142d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
blocking-basecamp: ? → +
You need to log in before you can comment on or make changes to this bug.