Closed Bug 796320 Opened 7 years ago Closed 7 years ago

Minor JSContext and JSRuntime clean-ups

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: njn, Assigned: njn)

Details

(Whiteboard: [js:t])

Attachments

(3 files)

I have some minor JSContext and JSRuntime clean-ups coming.
JSRuntime::waiveGCQuota is dead.
Attachment #666819 - Flags: review?(luke)
AutoSetGeneratingError is dead.  (An AutoScopedAssign<bool> is now used for
modifying cx->generatorError instead.)

(Hmm... isn't "AutoScoped" redundant?)
Attachment #666821 - Flags: review?(luke)
JSContext::lastMessage isn't needed.
Attachment #666822 - Flags: review?(luke)
Comment on attachment 666819 [details] [diff] [review]
(part 1) - Remove dead JSRuntime::waiveGCQuota.

but but but what if a binary addon is #including jscntxt.h and using this field to store a private pointer!
Attachment #666819 - Flags: review?(luke) → review+
Attachment #666821 - Flags: review?(luke) → review+
Comment on attachment 666822 [details] [diff] [review]
(part 3) - Remove JSContext::lastMessage.

Hah
Attachment #666822 - Flags: review?(luke) → review+
You need to log in before you can comment on or make changes to this bug.