796320 - Minor JSContext and JSRuntime clean-ups

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

I have some minor JSContext and JSRuntime clean-ups coming.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove dead JSRuntime::waiveGCQuota.

JSRuntime::waiveGCQuota is dead.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove dead AutoSetGeneratingError.

AutoSetGeneratingError is dead.  (An AutoScopedAssign<bool> is now used for
modifying cx->generatorError instead.)

(Hmm... isn't "AutoScoped" redundant?)

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove JSContext::lastMessage.

JSContext::lastMessage isn't needed.

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 666819 [details] [diff] [review]
(part 1) - Remove dead JSRuntime::waiveGCQuota.

but but but what if a binary addon is #including jscntxt.h and using this field to store a private pointer!

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 666822 [details] [diff] [review]
(part 3) - Remove JSContext::lastMessage.

Hah

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9cc5f638610
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdbc91e1e7db
https://hg.mozilla.org/integration/mozilla-inbound/rev/7efe6f0c30e6

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d9cc5f638610
https://hg.mozilla.org/mozilla-central/rev/bdbc91e1e7db
https://hg.mozilla.org/mozilla-central/rev/7efe6f0c30e6