796329 - [b2g-bluetooth] StopSendingFile() does not work

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

We've already had a StopSendingFile() in nsIDOMBluetoothAdapter, however it doesn't actually stop file-sending process.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: implemented StopSendingFile()

Send OBEX command "Abort" to terminate current operation (PUT).

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 666848 [details] [diff] [review]
patch 1: implemented StopSendingFile()

Review of attachment 666848 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, though I do wonder about the thread for the ring.

::: dom/bluetooth/BluetoothOppManager.cpp
@@ +242,5 @@
>      } else {
> +      if (mAbortFlag) {
> +        SendAbortRequest();
> +      } else {
> +        nsCOMPtr<nsIThread> t;

Doesn't this thread scope out at the end of this block?

Comment 3

[Eric Chou [:ericchou] [:echou]]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #2)
> Comment on attachment 666848 [details] [diff] [review]
> patch 1: implemented StopSendingFile()
> 
> Review of attachment 666848 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, though I do wonder about the thread for the ring.
> 
> ::: dom/bluetooth/BluetoothOppManager.cpp
> @@ +242,5 @@
> >      } else {
> > +      if (mAbortFlag) {
> > +        SendAbortRequest();
> > +      } else {
> > +        nsCOMPtr<nsIThread> t;
> 
> Doesn't this thread scope out at the end of this block?

Yes, you are right! I'll fix it.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: implemented StopSendingFile() and fixed potential memory problem, r=qdot

Comment 5

[Eric Chou [:ericchou] [:echou]]

try:

https://tbpl.mozilla.org/?tree=Try&rev=74431b7cfc37
https://tbpl.mozilla.org/?tree=Try&rev=04dce929a5e0

Comment 6

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: final: implemented StopSendingFile() and fixed potential memory problem, r=qdot

Avoid creating thread each time we send PUT request

Comment 7

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2af592592319

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2af592592319