796365 - Contenteditable doesn't bring up keyboard

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Description

[GH to BZ]

[GitHub issue by lsblakk on 2012-06-20T17:19:39Z, https://github.com/mozilla-b2g/gaia/issues/1837]
On a Nexus S that was just flashed yesterday (06-19-2012) when I run the UI Tests app and try the Keyboard tests, go to the Contenteditable section and touch the "Edit Me!" text I get a cursor but the keyboard does not come up for editing.

Comment 1

[GH to BZ]

[GitHub comment by timdream on 2012-06-21T03:08:39Z]
At first I think it's related to https://bugzilla.mozilla.org/show_bug.cgi?id=766549 but that bug is not landed yet! 

@vingtetun @RudyLu

Comment 2

[Martijn Wargers (dead)]

See:
http://people.mozilla.org/~mwargers/tests/contenteditable/contenteditable.htm
http://people.mozilla.org/~mwargers/tests/contenteditable/designmode.htm
for testcases.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I am not sure this is blocking-basecamp+.
Nominate this as blocking-basecamp?

Comment 4

[Yuan Xulei [:yxl] (Leave from May 18)]

Attachment: Treat contenteditable as a special text field to bring up the keyboard

Comment 5

[Martijn Wargers (dead)]

I guess that patch doesn't work for the designMode document case, right?

Comment 6

[Alex Keybl [:akeybl]]

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "remaining P1 bugs not already milestoned for C1".

Comment 7

[Yuan Xulei [:yxl] (Leave from May 18)]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #5)
> I guess that patch doesn't work for the designMode document case, right?

Yes, not for the designMode. Thanks for providing the test cases. I think we need another bug to fix the designMode as way to deal with it is a little different.

Comment 8

[Yuan Xulei [:yxl] (Leave from May 18)]

Bug 811177(https://bugzilla.mozilla.org/show_bug.cgi?id=811177) was created to track the designMode issue.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 680556 [details] [diff] [review]
Treat contenteditable as a special text field to bring up the keyboard

No need for gaia approvals for blocking-basecamp bugs.

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

Will push in a minute.

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22360b84eb87

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/22360b84eb87

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e74fe221ddcf

Comment 14

[Yuan Xulei [:yxl] (Leave from May 18)]

Comment on attachment 680556 [details] [diff] [review]
Treat contenteditable as a special text field to bring up the keyboard

Recover the patch that was marked as obsolete by mistake.

Comment 15

[Walter Chen[:ypwalter][:wachen]]

http://0rz.tw/uFCwf is created for people to access http://people.mozilla.org/~mwargers/tests/contenteditable/contenteditable.htm

http://0rz.tw/4xy5I is created for people to access http://people.mozilla.org/~mwargers/tests/contenteditable/designmode.htm

I verified it in 2013-01-20-07-02-02 pvt nightly b2g18 build.