796519 - Nit - When accessing a network on the wifi page that requires a username/password, use username, not identifier

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[GH to BZ]

[GitHub issue by jds2501 on 2012-08-23T00:41:35Z, https://github.com/mozilla-b2g/gaia/issues/3736]
## Build

* Device: Otoro
* Gaia: b92f1e1ab3c0818efd051de9fafcdc19867d42c9
* Mozilla Central: a614b730ca8e4358c428142b96de9828b8117991

## Steps

1. Go to settings
2. Go to wifi
3. Select the wifi checkbox
4. Select a network that requires a username and a password to access

## Expected

The first field should be labeled "username"

## Actual

The first field is labeled "identifier" - this is ambiguous against it's purpose, as the first value is intentionally a "username."

Comment 1

[Schalk Neethling [:espressive]]

Is this still an open bug?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Schalk Neethling [:espressive] from comment #1)
> Is this still an open bug?

Can't tell. I don't have access to a wifi point that happens to use a username and password in my location now.

Comment 3

[Schalk Neethling [:espressive]]

From looking at the latest code in master this is still the case:
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L66

Is it 'ok' to change strings at this stage, and if so, to which branch should this change be pushed?

Comment 4

[[e-mail]]

Harly could you confirm the proper naming?

Comment 5

[Harly Hsu[:harly]]

Username sounds like the proper naming, but still needinfo Omega as he is the UX owner for Settings.

Comment 6

[Omega Feng [:Omega] [:馮於懋]]

Yes, please use "Username" instead of "Identifier".

Comment 7

[[e-mail]]

Arthur, is carrier identity the same as wifi identity?

wifi
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/wifi_auth.html#L47

carrier
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/carrier_data_settings.html#L34

Comment 8

[[e-mail]]

(because they share the same string)

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

No, they are different.

Comment 10

[[e-mail]]

Attachment: pull request redirect to github

I reuse wifi-name and wifi-password for wording. Should I create new one?

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Not sure if this is a valid bug. The word "identity" is general in WiFi use cases[1]. Chuck, could you confirm whether it is reasonable to replace it with "name" or "user name"? 

[1]: http://itshelpdesk.files.wordpress.com/2011/05/android-wifi.png

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8388966 [details] [review]
pull request redirect to github

Clear the flag per comment 11. I would like to make sure the string change is reasonable.

Comment 13

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

"Identity" is the formal name for the argument.
I think change to "Username" is acceptable since it's common phrase asking for login, and can be more user friendly. But might cause some trouble if the the Wifi Provider do use the word "Identity" in the connection guide.
On the other hand, I don't think use "Name" is a good idea. It's not common and might imply asking for user's real name more than user's login name.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, Chuck!

Omega, could you make a final decision on the basis of comment 13? Thanks!

Comment 15

[Omega Feng [:Omega] [:馮於懋]]

Thanks for your input. I think we should use "Username". It's easier to understand.
If Wi-Fi provider uses "Identity" in the connection guide, it's still not so hard for users to associate it with "Username".

Comment 16

[[e-mail]]

Comment on attachment 8388966 [details] [review]
pull request redirect to github

Thanks omega to clarify the wording.

I create new l10n string wifi-auth-username/wifi-auth-password for this case.

Please kindly review it again.

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8388966 [details] [review]
pull request redirect to github

Thanks for the patch. Please also update wifi_join_hidden.html for consistency.

Comment 18

[[e-mail]]

Comment on attachment 8388966 [details] [review]
pull request redirect to github

create extra wifi-join-username/crete wifi-join-password l10n string for wifi-join-hidden page

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8388966 [details] [review]
pull request redirect to github

r=me, thanks!

Comment 20

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/0701e08a025787481a5d23443c75be7473c866f5

thanks!