796530 - [keyboard] No Keyboard support for Spanish Latin America

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[GH to BZ]

[GitHub issue by nhirata on 2012-08-24T21:55:58Z, https://github.com/mozilla-b2g/gaia/issues/3809]
## Environment :
Otoro Self Build 8/24/2012:
b2g commit cbe973c21ad4020e6e9092abaaa92bb02cbd4800
gaia commit 202154144ec2b6e01a352577ffb4f953f9bd916b

## Repro :
1. go to settings -> keyboard

## Expected :
1. Latin American Spanish

## Actual :
1. Spanish is listed, but I believe that it's only Es-es?  I looked at the keyboard layout and it showed an euro for currency.
2. Part of the requirements

Comment 1

[GH to BZ]

[GitHub comment by RudyLu on 2012-09-06T06:20:15Z]
1. About the currency symbol, it is per the spec,
    P. 5 of https://www.dropbox.com/sh/pz8qn4023f19dhr/Xd-dB0xkBj/Keyboard_Specs.pdf
    
cc @rafaelrebolleda & @caseyyee

Comment 2

[GH to BZ]

[GitHub comment by rafaelrebolleda on 2012-09-06T07:13:36Z]
Page 5 of that very same document says the currency symbol should be localized. Other than that, the layout should be the same, at least for V1.

Comment 3

[GH to BZ]

[GitHub comment by autonome on 2012-09-14T16:38:49Z]
Not blocking basecamp V1 release.

Comment 4

[Raniere Silva]

Attachment: Layout for Latin America

Comment 5

[Raniere Silva]

I need a little help from someone that lives in Peru and Venezuela for improve my patch.

Comment 6

[Guillermo López :willyaranda (probably SLOW response)]

Arturo, do you prefer to have the $ instead of € as the default currency symbol?


@Raniere: remember that there is only one Spanish ("es") locale.

Comment 7

[Arturo Martínez [:ThePhoenixBird]]

I would prefer $, Latin American keyboards with Ñ have $ instead of the euro.

Comment 8

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8425428 [details] [review]
Layout for Latin America

Two remarks, first, I think we should group all these layouts into one single layout: Spanish (Latin America) or Spanish (Americas). This is also how Android does it, and we don't need to add 6 keyboard layouts that are exactly the same.

Second, see my comments on GH on the actual code (small remarks).

Please re-set the r? flag to me after this has been addressed. Thanks!

Comment 9

[Raniere Silva]

Attachment: Layout for Latin America

Comment 10

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8427288 [details] [review]
Layout for Latin America

I renamed it to Espanol (Latinoamerica) after consulting with Spanish colleague, but other than that good job. Thanks Raniere!

Landed in https://github.com/mozilla-b2g/gaia/commit/b2c5e4145a00e275cb92045b3aa65e27ccd28519