Closed
Bug 796669
Opened 12 years ago
Closed 10 years ago
Bring the settings button on screen a bit more and increase its size to allow for a bigger click range
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Firefox OS Graveyard
Gaia::Calendar
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ghtobz, Assigned: leo.bugzilla.gaia)
References
Details
(Whiteboard: [label:calendar][label:polish])
Attachments
(3 files)
[GitHub issue by jds2501 on 2012-09-18T00:59:50Z, https://github.com/mozilla-b2g/gaia/issues/4839] ## Build * Device: Otoro * Gaia: 97a730d0457c62a5811198cd9ae1f758bcfbb715 * Mozilla Central: d3bb93eead1bdd12d0596dc52a20c813287449b8 ## Issue Nit-pick - I'd bring the calendar menu option a bit more on screen and increase the click range for the button. It's a bit too small to be clicked on in the Otoro, although definitely possible to do so.
Updated•12 years ago
|
Component: Gaia → Gaia::Calendar
I have brought the menu button a bit more on screen and increased the click range for the button. Please find the pointer for pull request for the patch at https://github.com/mozilla-b2g/gaia/pull/8115. Please review the patch.
Updated•11 years ago
|
Attachment #714292 -
Flags: review?(kgrandon)
Comment 4•11 years ago
|
||
I am concerned about this fix as this makes a change to only local building blocks of calendar (not sure why Calendar has a copy of them). We see in the default that it is set to a different value - so it seems like we should be changing it in both places. We would definitely need a screenshot and to ask for UX approval here I think. leo - can you attach a screenshot and we'll get confirmation from UX? Thanks!
Flags: needinfo?(leo.bugzilla.gaia)
Comment 7•11 years ago
|
||
Comment on attachment 715322 [details]
Screenshot with patch
Hi Casey - I'm just trying to get some UX feedback on these changes. I think that if we should make these they should probably go into /shared and not just this single app. It seems odd to me that we should do this for just one app. Thanks!
Attachment #715322 -
Flags: review?(kyee)
Comment 8•11 years ago
|
||
Comment on attachment 714292 [details]
Pointer to pull request
Pavel - adding you as a reviewer too as you might know the CSS landscape better than I. I'm just concerned about changing this, but not any other apps. Thanks!
Attachment #714292 -
Flags: review?(pivanov)
Comment 9•11 years ago
|
||
The patch look simple, bug do you try to use the header building blog?
Comment 10•11 years ago
|
||
@pavel - I am specifically worried about only doing this for calendar and not on a global level. If we do this for calendar the header will look different than other apps.
Comment 11•11 years ago
|
||
Thats why I want to use [BB] :) if we need to make changes like this one ... we need to make changes in [BB]
Comment 12•11 years ago
|
||
Kevin, This is a super-old issue that was addressed by making the drawer button hit-area larger. The change was applied to the BB's after the original issue was filed. Because of this, I don't think it's necessary to increase the size of the drawer icon if we apply the proper building block for it.
Comment 13•11 years ago
|
||
Comment on attachment 715322 [details] Screenshot with patch See comment #12
Comment 14•11 years ago
|
||
Comment on attachment 714292 [details]
Pointer to pull request
It appears that the current solution does not match up to the current building block code. Please check the current building block code, and ensure that our local copy matches. If we need to make any updates, we should make updates to both places.
I believe the current code is in: /shared/style/headers.css
Attachment #714292 -
Flags: review?(pivanov)
Attachment #714292 -
Flags: review?(kgrandon)
Updated•11 years ago
|
Attachment #715322 -
Flags: review?(kyee)
Comment 15•11 years ago
|
||
Comment on attachment 714292 [details]
Pointer to pull request
I think this is fine, but I would also like Pavel to review it if possible.
Attachment #714292 -
Flags: review?(pivanov)
Updated•11 years ago
|
Attachment #714292 -
Flags: review+
Comment 16•11 years ago
|
||
Please See comment #12 We need to increase the hit-area, not to change the visuals. Currently we have 5rem here : https://github.com/mozilla-b2g/gaia/blob/master/shared/style/headers.css#L222 If you need more info just ping me on IRC or here/email.
Comment 17•11 years ago
|
||
Comment on attachment 714292 [details]
Pointer to pull request
What Pavel has said makes total sense. As we already have a 5rem hit-target, I'm not sure it makes sense to increase this any further? Anyway, I'm clearing the review flag for now.
If we want a larger hit area, that would be fine. Otherwise I believe that this should be driven by UX.
Attachment #714292 -
Flags: review?(pivanov)
Attachment #714292 -
Flags: review+
Assignee | ||
Comment 18•11 years ago
|
||
hmm, the increase in the hit area totally serves the purpose. I would like to know, if i want to make changes for UX how can i propose to UX team. thanks
Comment 19•10 years ago
|
||
The calendar drawer button is larger and has a larger hit area now since the 2.0 redesign, marking this as fixed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•