796790 - Video app gives me a black screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[GH to BZ]

[GitHub issue by dmandelin on 2012-09-28T21:41:06Z, https://github.com/mozilla-b2g/gaia/issues/5461]
STR:

1. Set up new phone with no videos.
2. Start video app.

Actual result: Black screen. Notification bar still visible. Home button still works.
Expected result: Not a black screen.

Comment 1

[GH to BZ]

[GitHub comment by nhirata on 2012-09-28T22:54:45Z]
Hi dmandelin, just trying to understand the situation : 
- Do you have any videos on your SDcard? 
- Also how long did you want for it to show anything?  First time loading, I find I have to wait up to 15 seconds or so before anything shows...  (that in itself should be a perf bug)

Comment 2

[GH to BZ]

[GitHub comment by dmandelin on 2012-09-28T22:58:02Z]
1. No, I don't have any videos on my SD card.
2. I tried again, and this time waited for about a minute and still nothing had showed.

Comment 3

[Alex Keybl [:akeybl]]

[mass adding reproducible keyword for any open Gaia bug with the word "STR:" in comments]

Comment 4

[Dietrich Ayala (:dietrich)]

Blocking+. We can't ship an app that has an empty black screen as it's default view.

Comment 6

[Piotr Zalewa [:zalun]]

r? https://github.com/mozilla-b2g/gaia/pull/5880

Comment 7

[Dietrich Ayala (:dietrich)]

Piotr, can you summarize your approach in solving this, preferably with screenshot?

Offhand I'd say it should match the Music message.

Ben, can you review?

Comment 8

[Piotr Zalewa [:zalun]]

Attachment: Message displayed if no videos are present on the device

Comment 9

[Piotr Zalewa [:zalun]]

The text was there before - see https://github.com/mozilla-b2g/gaia/blob/master/apps/video/locales/video.en-US.properties#L3

As of the method, if there is no video in the videodb it doesn't enumerate even once so hasVideo stays false. In this case I showOverlay with 'empty' message. This is the way how 'nocard' and 'pluggedin' messages are presented to the user.

Comment 11

[Piotr Zalewa [:zalun]]

There is a new comment in the pull request - I'll change the code and create a new  pull request

Comment 12

[Piotr Zalewa [:zalun]]

r? https://github.com/mozilla-b2g/gaia/pull/6055

Comment 13

[Piotr Zalewa [:zalun]]

I'm still waiting for the device - until then I will not be able to fix that bug

Comment 14

[Dale Harvey (:daleharvey)]

Yeh this is definitely fiddly to code without a device, I will steal it and base it on your patches, Cheers

Comment 15

[Dale Harvey (:daleharvey)]

Attachment: Show dialog if there are no videos to display

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 676599 [details]
Show dialog if there are no videos to display

Thanks together for the work. Let's kill all blocking-basecamp!