Closed Bug 796827 Opened 7 years ago Closed 7 years ago

[b2g-bluetooth] Destroy BluetoothHfpManager instance while in shutdown

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: gyeh, Assigned: gyeh)

References

Details

Attachments

(1 file, 4 obsolete files)

No description provided.
Follow up of Bug 791197
Attached patch v1 patch (obsolete) — Splinter Review
Attachment #666874 - Flags: review?(kyle)
Comment on attachment 666874 [details] [diff] [review]
v1 patch

Review of attachment 666874 [details] [diff] [review]:
-----------------------------------------------------------------

The fact that the diff isn't lining up worries me. Looks good otherwise, but would like to make sure the diff is what is expected before r+'ing. Re-r? after either fixing or telling me I'm crazy. :)

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +36,5 @@
> +
> +namespace {
> +
> +StaticRefPtr<BluetoothHfpManager> gBluetoothHfpManager;
> +

Nit: Don't need extra newlines between this and other statics.

@@ +106,5 @@
>    : mCurrentVgs(-1)
>    , mCurrentCallIndex(0)
>    , mCurrentCallState(nsIRadioInterfaceLayer::CALL_STATE_DISCONNECTED)
>  {
> +bool

So I think your diff may be off here. Splinter is showing Init() to be /in/ the constructor?

@@ +342,5 @@
> +{
> +  MOZ_ASSERT(NS_IsMainThread());
> +
> +  gInShutdown = true;
> +

Nit: We don't need all of these extra newlines.
Attachment #666874 - Flags: review?(kyle)
Attached patch v2 patch (obsolete) — Splinter Review
Oops, you got me! I found it after attaching the patch :p
Attachment #666874 - Attachment is obsolete: true
Attachment #666885 - Flags: review?(kyle)
Attached patch v2 patch (obsolete) — Splinter Review
register NS_XPCOM_SHUTDOWN_OBSERVER_ID in Init()
Attachment #666885 - Attachment is obsolete: true
Attachment #666885 - Flags: review?(kyle)
Attachment #666891 - Flags: review?(kyle)
Attached patch v2 patch (obsolete) — Splinter Review
remove observers of mozsettings-changed in Cleanup()
Attachment #666891 - Attachment is obsolete: true
Attachment #666891 - Flags: review?(kyle)
Attachment #666894 - Flags: review?(kyle)
Attachment #666894 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/fd238b14ba35
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Duplicate of this bug: 794346
You need to log in before you can comment on or make changes to this bug.