796880 - better diagnostics when parent terminates before children

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: better diags

In bug 796840, there is a case where mozprocess gets upset if a parent process terminates while children are alive.  The diagnostics in this case could be better - eg, listing the children PIDs would offer clues about what has gone wrong.  This patch improves the messages printed in this case, including printing the child PIDs.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: forgot to qref - prints the parent pid

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: self.pid is what we need!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

*sigh* - printing .keys() won't do the right thing in py3k IIRC - list(ob.keys()) will.

Comment 4

[Jeff Hammel]

mozprocess is actually part of mozbase: https://wiki.mozilla.org/Auto-tools/Projects/MozBase ; it should be fixed in its repo and mirrored to m-c; :gps, mind if one of us steals this review?

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 666979 [details] [diff] [review]
self.pid is what we need!

Review of attachment 666979 [details] [diff] [review]:
-----------------------------------------------------------------

Someone else should fix mozprocess issues.

There is also bug 795427 around more useful error messages for mach. Perhaps _run_command should have a try..finally for trapping exit and cleaning up child processes better?

Comment 6

[Jeff Hammel]

Attachment: same as above but versus mozbase repo and with string formatting changes

Comment 7

[William Lachance (:wlach)]

Comment on attachment 667040 [details] [diff] [review]
same as above but versus mozbase repo and with string formatting changes

LGTM

Comment 8

[Jeff Hammel]

pushed to mozbase: https://github.com/mozilla/mozbase/commit/ae6780c717534d64d03919f7b2ee40e56e21cdba

We will mirror to m-c soon

Comment 9

[Jeff Hammel]

oops: https://github.com/mozilla/mozbase/commit/09cdf477993f2d5e5a667400fb5a778cac941fe1

Comment 10

[Mark Hammond [:markh] [:mhammond]]

Seeing this is still open, I'll report this here.  The code as checked in will cause:

Traceback (most recent call last):
  File "o:\src\mm\mozilla-hg\mc-socialapi-landing\testing/mozbase/mozprocess\mozprocess\processhandler.py", line 297, in _procmgr
    self._poll_iocompletion_port()
  File "o:\src\mm\mozilla-hg\mc-socialapi-landing\testing/mozbase/mozprocess\mozprocess\processhandler.py", line 333, in _poll_iocompletion_port
    print >> sys.stderr, "PIDS: %s" %  ', '.join(self._spawned_procs.keys())
TypeError: sequence item 0: expected string, long found

So we probably need something like:

    print >> sys.stderr, "PIDS: %s" %  ', '.join([str(p) for p in self._spawned_procs.keys()])

Comment 11

[Mark Hammond [:markh] [:mhammond]]

And we can just drop .keys()

    print >> sys.stderr, "PIDS: %s" %  ', '.join([str(p) for p in self._spawned_procs])

Comment 12

[Jeff Hammel]

Attachment: follow up

Comment 13

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 668241 [details] [diff] [review]
follow up

Looks good and WFM

Comment 14

[Jeff Hammel]

pushed: https://github.com/mozilla/mozbase/commit/821c01dcba5d85d952c4e89053808f695cf2b93f