796909 - Use 2x Images on About:Home for HiDPI

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Stephen Horlander [:shorlander]]

Attachment: AboutHome HiDPI Assets - i01

Now that bug 781327 has landed we should update about:home to be sharp in HiDPI also.

Attaching the @2x assets. The search engine logo is currently a data URI, I will attach that separate.

Comment 1

[Stephen Horlander [:shorlander]]

Attachment: Google Logo Data URI - i01

Comment 2

[Frank Yan (:fryn)]

Attachment: part 1

This was a bit tricky, because we're displaying these images as generated content, but I tackled it with some CSS3. ;)

(Someday, when we merge about:home and about:newtab, we'll pull all the about:home theme code out of browser/base/.)

Comment 3

[Frank Yan (:fryn)]

Attachment: part 2: HiDPI search engine logo

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 667228 [details] [diff] [review]
part 2: HiDPI search engine logo

Review of attachment 667228 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/abouthome/aboutHome.js
@@ +174,5 @@
>      logoElt.src = searchEngineInfo.image;
> +#ifdef XP_MACOSX
> +    if (searchEngineInfo.imageHD && window.matchMedia("(min-resolution: 2dppx)"))
> +      logoElt.src = searchEngineInfo.imageHD;
> +#endif

I suppose, in theory, that putting in an actual CSS @media rule (to control display of a low-res or hi-res image) would be nice for the potential future such that dragging the window from a low-to-high-dpi monitor would be ideal... But I'll take this as a simple patch that we can make better in the future with image-set anyway.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: AboutHome HiDPI Assets - i02

Added Snippet Icons.

Comment 6

[Frank Yan (:fryn)]

Attachment: part 1 v2

Added the new default snippet images from "AboutHome HiDPI Assets - i02".

Comment 7

[Frank Yan (:fryn)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d536fb994aff
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecece4b1c684

Thanks for the reviews! :)

We'll update the Firefox logo image in a followup bug (which will also allow us to remove about-logo.png from a few directories).

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d536fb994aff
https://hg.mozilla.org/mozilla-central/rev/ecece4b1c684