Use 2x Images on About:Home for HiDPI

RESOLVED FIXED in Firefox 18

Status

()

--
enhancement
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: shorlander, Assigned: fryn)

Tracking

unspecified
Firefox 18
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Created attachment 666973 [details]
AboutHome HiDPI Assets - i01

Now that bug 781327 has landed we should update about:home to be sharp in HiDPI also.

Attaching the @2x assets. The search engine logo is currently a data URI, I will attach that separate.
(Reporter)

Comment 1

6 years ago
Created attachment 666975 [details]
Google Logo Data URI - i01
(Assignee)

Comment 2

6 years ago
Created attachment 667141 [details] [diff] [review]
part 1

This was a bit tricky, because we're displaying these images as generated content, but I tackled it with some CSS3. ;)

(Someday, when we merge about:home and about:newtab, we'll pull all the about:home theme code out of browser/base/.)
Assignee: nobody → fryn
Status: NEW → ASSIGNED
Attachment #667141 - Flags: review?(dolske)
(Assignee)

Comment 3

6 years ago
Created attachment 667228 [details] [diff] [review]
part 2: HiDPI search engine logo
Attachment #667228 - Flags: review?(dolske)
Comment on attachment 667228 [details] [diff] [review]
part 2: HiDPI search engine logo

Review of attachment 667228 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/abouthome/aboutHome.js
@@ +174,5 @@
>      logoElt.src = searchEngineInfo.image;
> +#ifdef XP_MACOSX
> +    if (searchEngineInfo.imageHD && window.matchMedia("(min-resolution: 2dppx)"))
> +      logoElt.src = searchEngineInfo.imageHD;
> +#endif

I suppose, in theory, that putting in an actual CSS @media rule (to control display of a low-res or hi-res image) would be nice for the potential future such that dragging the window from a low-to-high-dpi monitor would be ideal... But I'll take this as a simple patch that we can make better in the future with image-set anyway.
Attachment #667228 - Flags: review?(dolske) → review+
(Assignee)

Updated

6 years ago
Attachment #667141 - Attachment description: patch → part 1
(Reporter)

Comment 5

6 years ago
Created attachment 667602 [details]
AboutHome HiDPI Assets - i02

Added Snippet Icons.
Attachment #666973 - Attachment is obsolete: true
(Assignee)

Comment 6

6 years ago
Created attachment 667864 [details] [diff] [review]
part 1 v2

Added the new default snippet images from "AboutHome HiDPI Assets - i02".
Attachment #667141 - Attachment is obsolete: true
Attachment #667141 - Flags: review?(dolske)
Attachment #667864 - Flags: review?(dolske)
Attachment #667864 - Flags: review?(dolske) → review+
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d536fb994aff
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecece4b1c684

Thanks for the reviews! :)

We'll update the Firefox logo image in a followup bug (which will also allow us to remove about-logo.png from a few directories).
Target Milestone: --- → Firefox 18

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/d536fb994aff
https://hg.mozilla.org/mozilla-central/rev/ecece4b1c684
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.