796927 - xpcom does not compile on armv6 (sb2) for raspberry pi

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Oleg Romashin (:romaxa)]

arm-unknown-linux-gnueabi-g++ -o xptcinvoke_arm.o -c  -fvisibility=hidden -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -DEXPORT_XPTC_API -D_IMPL_NS_COM -I/xpcom/reflect/xptcall/src/md/unix/../.. -I/xpcom/reflect/xptcall/src/md/unix/../../../../xptinfo/src  -I/xpcom/reflect/xptcall/src/md/unix -I. -I../../../../../../dist/include  -I/obj-build-b2g-rsppi/dist/include/nspr -I/obj-build-b2g-rsppi/dist/include/nss      -fPIC -I/usr/include/arm-linux-gnueabihf -I/opt/vc/include -pedantic -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wno-ctor-dtor-privacy -Wno-overlength-strings -Wno-invalid-offsetof -Wno-variadic-macros -Wno-long-long -march=armv6zk -mfpu=vfp -mfloat-abi=hard -fno-exceptions -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -O3 -g -mapcs-frame -fno-omit-frame-pointer  -O2  -I/usr/include/arm-linux-gnueabihf -I/opt/vc/include -DMOZILLA_CLIENT -include ../../../../../../mozilla-config.h -MD -MF .deps/xptcinvoke_arm.o.pp  /xpcom/reflect/xptcall/src/md/unix/xptcinvoke_arm.cpp
/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_arm.cpp: In function 'nsresult NS_InvokeByIndex_P(nsISupports*, uint32_t, uint32_t, nsXPTCVariant*)':
/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_arm.cpp:404:10: error: invalid conversion from 'uint32_t {aka unsigned int}' to 'nsresult {aka tag_nsresult}' [-fpermissive]
make[1]: *** [xptcinvoke_arm.o] Error 1

Comment 1

[Oleg Romashin (:romaxa)]

simple cast of result to (nsresult) on return works ok.

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: use nsresult instead of uint32_t

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: gfx add cstring include for memcpy

I guess it should be ok

Comment 4

[Joe Drew (not getting mail)]

Comment on attachment 668318 [details] [diff] [review]
use nsresult instead of uint32_t

Review of attachment 668318 [details] [diff] [review]:
-----------------------------------------------------------------

I think you uploaded the wrong patch. The name doesn't match the contents.

Comment 5

[Joe Drew (not getting mail)]

Comment on attachment 668318 [details] [diff] [review]
use nsresult instead of uint32_t

Ah, figured it out, patches are reversed.

Comment 6

[Siarhei Siamashka]

Comment on attachment 668318 [details] [diff] [review]
use nsresult instead of uint32_t

Review of attachment 668318 [details] [diff] [review]:
-----------------------------------------------------------------

r+ (not sure if/how I can change the "review?" attachment flag)

Comment 7

[Joe Drew (not getting mail)]

Comment on attachment 668318 [details] [diff] [review]
use nsresult instead of uint32_t

You definitely can change the review state; it's in the attachment details tab. But I'll do it for you :)

Comment 8

[Siarhei Siamashka]

(In reply to Joe Drew (:JOEDREW! \o/) from comment #7)
> You definitely can change the review state; it's in the attachment details
> tab.

I suspect that I'm just a victim of https://bugzilla.mozilla.org/show_bug.cgi?id=294021#c1 or something similar.

Comment 9

[Joe Drew (not getting mail)]

Why the devil don't you have editbugs?! I'll fix that.

Comment 10

[Oleg Romashin (:romaxa)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/0bea829361c3
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/13fd1d18cdf4

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0bea829361c3
https://hg.mozilla.org/mozilla-central/rev/13fd1d18cdf4