[Metro] Styling for preference panel section headings



Firefox for Metro
6 years ago
4 years ago


(Reporter: mbrubeck, Assigned: sfoster)



Windows 8.1

Firefox Tracking Flags

(Not tracked)


(Whiteboard: [metro-mvp][LOE:1][completed-elm])


(2 attachments)



6 years ago
Created attachment 667058 [details]
current screenshot

The section headings in the metro prefs panel are currently unstyled; they look just like the other text in the panel (see attached screenshot).  We should choose a heading font to make these stand out more.  Also, we should remove the redundant "Preferences" heading (there are two of them).

Yuan or Stephen, do you want to specify styles for this?  Or I can just start by making the font bold and slightly larger...


6 years ago
Component: Theme → General
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk


6 years ago
Whiteboard: [metro-beta] → [metro-mvp]

Comment 1

6 years ago
Sam, can you take this bug when you get your development environment set up?  If we don't have specs from our designers yet, you could start by copying some of the font styles already used elsewhere in the Metro theme.
Assignee: nobody → sfoster
Whiteboard: [metro-mvp] → [metro-mvp][LOE:1]

Comment 3

5 years ago
Created attachment 679449 [details] [diff] [review]
Styles for the prefs panel settings titles to indicate heirarchy

This might be an interim measure depending on how the visual and interaction of this screen ends up. 
I ended up using descendant selectors to target the labels. I could have built the box > vbox > etc. child chain but it seemed needlessly ugly and brittle for a low-traffic area of the UI?
There is another a level of heirarchy already present in setting.group and setting.subgroup that seems to be treated differently - I didn't touch that. The goal was a fieldset-like treatment where the settings group titles a left-aligned with the other labels but diminished visually, with their child settings indented.
Attachment #679449 - Flags: review?(mbrubeck)

Comment 4

5 years ago
Comment on attachment 679449 [details] [diff] [review]
Styles for the prefs panel settings titles to indicate heirarchy

Looks good!  I'll push this to elm shortly.
Attachment #679449 - Flags: review?(mbrubeck) → review+

Comment 5

5 years ago
Whiteboard: [metro-mvp][LOE:1] → [metro-mvp][LOE:1][completed-elm]

Comment 6

5 years ago
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Last Resolved: 5 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.