797018 - [Metro] Styling for preference panel section headings

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: current screenshot

The section headings in the metro prefs panel are currently unstyled; they look just like the other text in the panel (see attached screenshot).  We should choose a heading font to make these stand out more.  Also, we should remove the redundant "Preferences" heading (there are two of them).

Yuan or Stephen, do you want to specify styles for this?  Or I can just start by making the font bold and slightly larger...

Comment 1

[Matt Brubeck (:mbrubeck)]

Sam, can you take this bug when you get your development environment set up?  If we don't have specs from our designers yet, you could start by copying some of the font styles already used elsewhere in the Metro theme.

Comment 2

[Matt Brubeck (:mbrubeck)]

Microsoft's Metro style guide on fonts:
http://msdn.microsoft.com/en-us/library/windows/apps/hh700394.aspx#ux_font_choice

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Styles for the prefs panel settings titles to indicate heirarchy

This might be an interim measure depending on how the visual and interaction of this screen ends up. 
I ended up using descendant selectors to target the labels. I could have built the box > vbox > etc. child chain but it seemed needlessly ugly and brittle for a low-traffic area of the UI?
There is another a level of heirarchy already present in setting.group and setting.subgroup that seems to be treated differently - I didn't touch that. The goal was a fieldset-like treatment where the settings group titles a left-aligned with the other labels but diminished visually, with their child settings indented.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 679449 [details] [diff] [review]
Styles for the prefs panel settings titles to indicate heirarchy

Looks good!  I'll push this to elm shortly.

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/projects/elm/rev/39b99788c0a0

Comment 6

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.