797021 - "background-clip: content-box, border-box" does not seem to work

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky, bz on IRC]]

testcase, to run from the srcdir:

<style>
  div { background-image: url(layout/reftests//backgrounds/aqua-32x32.png),
                          url(layout/reftests//backgrounds/green-16x20.png);
        border: 20px solid transparent;
        background-clip: content-box, border-box;
        width: 100px; height: 100px; }
</style>
<div></div>

This shows only aqua, no green.  That seems broken to me...

Comment 1

[Hector Zhao [:hectorz]]

Also seeing this, works on beta (17), broken on aurora(18).

Comment 2

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Oh, interesting!  I didn't realize this used to work.

Hector, are you willing to find a regression range?

Comment 3

[Hector Zhao [:hectorz]]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Oh, interesting!  I didn't realize this used to work.
> 
> Hector, are you willing to find a regression range?

I'd like to, just need to be patient for the slow downloading.

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

OK.  Let me know if you're having trouble with it, alright?

Comment 5

[Hector Zhao [:hectorz]]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Oh, interesting!  I didn't realize this used to work.
> 
> Hector, are you willing to find a regression range?

And the regression range is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f36b93c70d05&tochange=e5af3d785252

Comment 6

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Hmm.  Probably a regression from bug 786502, then.

Chris, can you take a look?

Comment 7

[Chris Lord [:cwiiis]]

Attachment: Fix border clipping on backgrounds with multiple layers

Fix the issue. reftest patch incoming.

Comment 8

[Chris Lord [:cwiiis]]

Attachment: Reftest

Turn the test case in comment #0 into a reftest.

Comment 9

[Chris Lord [:cwiiis]]

hmm, not quite, this breaks another reftest...

https://tbpl.mozilla.org/?tree=Try&rev=bef23e002e21

Comment 10

[Chris Lord [:cwiiis]]

Attachment: Fix border clipping on backgrounds with multiple layers

Remember to draw all layers when aLayer < 0.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 677436 [details] [diff] [review]
Fix border clipping on backgrounds with multiple layers

Review of attachment 677436 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 12

[Chris Lord [:cwiiis]]

Pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/da40e6f95147
https://hg.mozilla.org/integration/mozilla-inbound/rev/324d0fbac2fd

Comment 13

[Chris Lord [:cwiiis]]

Will wait over the weekend, then assuming there are no problems, request aurora approval.

Comment 14

[Chris Lord [:cwiiis]]

Silly signed/unsigned follow-up to fix debug build bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/772a4bb004ad

Comment 15

[Ryan VanderMeulen [:RyanVM][PTO Jan 25 - Feb 2]]

https://hg.mozilla.org/mozilla-central/rev/da40e6f95147
https://hg.mozilla.org/mozilla-central/rev/324d0fbac2fd
https://hg.mozilla.org/mozilla-central/rev/772a4bb004ad

Comment 16

[Hector Zhao [:hectorz]]

(In reply to Chris Lord [:cwiiis] from comment #13)
> Will wait over the weekend, then assuming there are no problems, request
> aurora approval.

Hi,

Any ETA of this aurora uplift? Thanks!

Comment 17

[Chris Lord [:cwiiis]]

Comment on attachment 677436 [details] [diff] [review]
Fix border clipping on backgrounds with multiple layers

[Approval Request Comment]
Bug caused by (feature/regressing bug #): border clipping on multi-layer backgrounds breaks.
User impact if declined: Using this feature will result in incorrect rendering
Testing completed (on m-c, etc.): Been on m-c a while now with no apparent ill effect
Risk to taking this patch (and alternatives if risky): Low-Medium. I'd have thought breakage ought to be obvious, but I wouldn't want to assume.
String or UUID changes made by this patch: None.

Comment 18

[Chris Lord [:cwiiis]]

Comment on attachment 677375 [details] [diff] [review]
Reftest

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Test-case for the feature this bug fixes
User impact if declined: We may accidentally break this feature(?)
Testing completed (on m-c, etc.): Reftest has been running fine since push.
Risk to taking this patch (and alternatives if risky): Practically nil.
String or UUID changes made by this patch: None.

Comment 19

[Chris Lord [:cwiiis]]

Thanks for the reminder, Hector, I'd totally forgotten!

Comment 20

[Chris Lord [:cwiiis]]

Pushed to inbound:

https://hg.mozilla.org/releases/mozilla-aurora/rev/d422c11c91fe
https://hg.mozilla.org/releases/mozilla-aurora/rev/996854233577
https://hg.mozilla.org/releases/mozilla-aurora/rev/668d088cd209