Closed Bug 797066 Opened 11 years ago Closed 11 years ago

make javascript.options.mem.log only log the GC/CC details in the Console

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: Optimizer, Assigned: Optimizer)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v0.0
1.80 KB, patch
terrence
: review+
Details | Diff | Splinter Review 
since javascript.options.mem.notify has landed and is around for more than 3 months, javascript.options.mem.log should now not emit the notification containing GC/CC details.
I don't follow.  Didn't bug 773734 already do that?
No, and luckily, the patch attached to that bug is not the one that was checked in as the sudden change might have broken some addons. So doing it now.
Attached file Patch v0.0 (obsolete) — 
OR statement removal
Assignee: nobody → scrapmachines
Status: NEW → ASSIGNED
Attachment #667107 - Flags: review?(terrence)
Attachment #667107 - Attachment is obsolete: true
Attachment #667107 - Attachment is patch: false
Attachment #667107 - Flags: review?(terrence)
Attached patch Patch v0.0 — — Splinter Review 
OR removal patch.
Attachment #667111 - Flags: review?(terrence)
Comment on attachment 667111 [details] [diff] [review]
Patch v0.0

Review of attachment 667111 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #667111 - Flags: review?(terrence) → review+
Also I forgot to mention, thanks for doing the legwork to implement this!
np :)
It was fairly straight forward.
Otherwise, I have never touched C++ code of Firefox.
Whiteboard: [checkin-needed]
Keywords: checkin-needed
Whiteboard: [checkin-needed]
https://hg.mozilla.org/mozilla-central/rev/c92cb673ade1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.