Closed
Bug 797066
Opened 12 years ago
Closed 12 years ago
make javascript.options.mem.log only log the GC/CC details in the Console
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: Optimizer, Assigned: Optimizer)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.80 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
since javascript.options.mem.notify has landed and is around for more than 3 months, javascript.options.mem.log should now not emit the notification containing GC/CC details.
|
||
Comment 1•12 years ago
|
||
I don't follow. Didn't bug 773734 already do that?
|
Assignee | |
Comment 2•12 years ago
|
||
No, and luckily, the patch attached to that bug is not the one that was checked in as the sudden change might have broken some addons. So doing it now.
|
|
Assignee | |
Comment 3•12 years ago
|
||
OR statement removal
Assignee: nobody → scrapmachines
Status: NEW → ASSIGNED
Attachment #667107 -
Flags: review?(terrence)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #667107 -
Attachment is obsolete: true
Attachment #667107 -
Attachment is patch: false
Attachment #667107 -
Flags: review?(terrence)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 667111 [details] [diff] [review]
Patch v0.0
Review of attachment 667111 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #667111 -
Flags: review?(terrence) → review+
|
|
||
Comment 6•12 years ago
|
||
Also I forgot to mention, thanks for doing the legwork to implement this!
|
|
Assignee | |
Comment 7•12 years ago
|
||
np :)
It was fairly straight forward.
Otherwise, I have never touched C++ code of Firefox.
Whiteboard: [checkin-needed]
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin-needed]
|
||
Comment 8•12 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
|
|
||
Comment 9•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•