797102 - "Save Changes" should read "Save and exit"

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Julien Wajsberg [:julienw]]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120918042011

Steps to reproduce:

When editing a page, there are 2 buttons (in the top) to save changes:
- one is "save and keep editing"
- the other is "save changes".

I think "save changes" is confusing. BTW the button in the editor displays "save and exit" when hovering, so I think this could be the right wording for the top button as well.

Comment 1

[Eric Shepherd [:sheppy]]

I agree the button labels can be confusing to newcomers. This isn't a huge deal, of course, but it would be nice to tweak it.

Perhaps these should be "Save" and "Save and Exit". Personally, I think "Save" implies that you're not going to do anything but save changes. "Save Changes" sounds like you're not going to leave, but you do.

What do you think, Julien? Any other opinions?

Comment 2

[Julien Wajsberg [:julienw]]

Having both "Save" and "Save and exit" make it quite clear that "Save" doesn't exit :) So I like this.

Comment 3

[David Walsh :davidwalsh]

Bear in mind, if we change "Save" to "Save and Exit", then we need to change every "Save"  or "Submit" etc. button to "{term} and Exit".  The *one* place on the site that we have a special save-and-not-go-anywhere feature shouldn't be the one that dictates the consistency of the site.

"Save" and "Save and Continue" are really the best options, IMO.

Comment 4

[David Walsh :davidwalsh]

Speaking this through with Sheppy on IRC...

Comment 5

[Eric Shepherd [:sheppy]]

What I think we ought to do is this:

Change to use just two buttons:

Save: Saves but doesn't close the editor. Use Ctrl-S as the shortcut for this.

Close: Closes the editor, asking if you want to save if you haven't done so.

Comment 6

[Eric Shepherd [:sheppy]]

To be clear, we would then outright remove the "Discard" button; its functionality would be absorbed into "Close;" using that then answering "No" when asked if you want to save would do the same thing.

Comment 7

[Julien Wajsberg [:julienw]]

I'd be ok with this if "Save" is disabled when there is no change to save.

It still bothers me a little to have to click twice when I want to quit, but I could live with that. Well, I think I'd just close the window after saving anyway ;)

Comment 8

[Julien Wajsberg [:julienw]]

I thought about it during the night, and I'd say that what really matters as a user is to know if the editor is dirty (i.e. if there is changes to save). Disabling the "save" button when there is no change is just one way, but it could be another indicator.

Comment 9

[Eric Shepherd [:sheppy]]

(In reply to Julien Wajsberg from comment #8)
> I thought about it during the night, and I'd say that what really matters as
> a user is to know if the editor is dirty (i.e. if there is changes to save).
> Disabling the "save" button when there is no change is just one way, but it
> could be another indicator.

I've filed bug 797845 to request dimming the save button(s) when no changes exist to save.

Comment 10

[ali spivak]

Can we close this bug and use bug 797845 as the replacement?

Comment 11

[Eric Shepherd [:sheppy]]

(In reply to ali spivak from comment #10)
> Can we close this bug and use bug 797845 as the replacement?

Yep.