Closed
Bug 797199
Opened 12 years ago
Closed 12 years ago
Signaling - Unused methods should be removed from Call interface.
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ehugg, Unassigned)
Details
(Whiteboard: [WebRTC], [blocking-webrtc-], [qa-])
Attachments
(1 file, 1 obsolete file)
4.75 KB,
patch
|
jesup
:
feedback+
|
Details | Diff | Splinter Review |
Below is a clip from CC_SIPCCCall.cpp. The FIX comments detail where we should add the info to the dcb. 584 void CC_SIPCCCall::addIceCandidate(const std::string& strCandidate) 585 { 586 CSFLogDebug(logTag, "addIceCandidate %s", strCandidate.c_str()); 587 588 // FIX - add info to dcb for use when creating SDP 589 } 590 591 void CC_SIPCCCall::setLocalSourceAudioVideo(unsigned localSourceAudioTracks, uns igned localSourceVideoTracks) 592 { 593 CSFLogDebug(logTag, "setLocalSourceAudioVideo %d, %d", localSourceAudioTracks, localSourceVideoTracks); 594 595 // FIX - add info to dcb for use when creating SDP 596 } 597 598 void CC_SIPCCCall::setPeerConnection(const std::string& handle) 599 { 600 CSFLogDebug(logTag, "setPeerConnection"); 601 602 peerconnection = handle; // Cache this here. we need it to make the CC_SIPCCC allInfo 603 CCAPI_SetPeerConnection(callHandle, handle.c_str()); 604 605 // FIX - add info to dcb for use when creating SDP 606 } 607
Updated•12 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-]
Reporter | ||
Comment 1•12 years ago
|
||
Actually these functions do not need to be fixed. The first two need to be removed because they are not called, the third needs the comment removed because it does not apply.
Reporter | ||
Updated•12 years ago
|
Summary: Signaling - session information should be available in DCB. → Signaling - Unused methods should be removed from Call interface.
Reporter | ||
Comment 2•12 years ago
|
||
Reporter | ||
Comment 3•12 years ago
|
||
Reporter | ||
Updated•12 years ago
|
Attachment #667585 -
Attachment is obsolete: true
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 667618 [details] [diff] [review] Unused methods removed from CC_Call First patch was over-zealous with the trailing whitespace removal.
Attachment #667618 -
Flags: feedback?(rjesup)
Updated•12 years ago
|
Attachment #667618 -
Flags: feedback?(rjesup) → feedback+
Reporter | ||
Comment 5•12 years ago
|
||
Comment on attachment 667618 [details] [diff] [review] Unused methods removed from CC_Call Pushed to Alder - http://hg.mozilla.org/projects/alder/rev/27a4c0c98966
Reporter | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-], [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•