797199 - Signaling - Unused methods should be removed from Call interface.

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Ethan Hugg [:ehugg]]

Below is a clip from CC_SIPCCCall.cpp.  The FIX comments detail where we should add the info to the dcb.

 584 void CC_SIPCCCall::addIceCandidate(const std::string& strCandidate)
 585 {
 586   CSFLogDebug(logTag, "addIceCandidate %s", strCandidate.c_str());
 587 
 588   // FIX - add info to dcb for use when creating SDP
 589 }
 590 
 591 void CC_SIPCCCall::setLocalSourceAudioVideo(unsigned localSourceAudioTracks, uns
     igned localSourceVideoTracks)
 592 {
 593   CSFLogDebug(logTag, "setLocalSourceAudioVideo %d, %d", localSourceAudioTracks,
      localSourceVideoTracks);
 594 
 595   // FIX - add info to dcb for use when creating SDP
 596 }
 597 
 598 void CC_SIPCCCall::setPeerConnection(const std::string& handle)
 599 {
 600   CSFLogDebug(logTag, "setPeerConnection");
 601   
 602   peerconnection = handle;  // Cache this here. we need it to make the CC_SIPCCC
     allInfo
 603   CCAPI_SetPeerConnection(callHandle, handle.c_str());
 604 
 605   // FIX - add info to dcb for use when creating SDP
 606 }
 607

Comment 1

[Ethan Hugg [:ehugg]]

Actually these functions do not need to be fixed.  The first two need to be removed because they are not called, the third needs the comment removed because it does not apply.

Comment 2

[Ethan Hugg [:ehugg]]

Attachment: Unused methods removed from CC_Call

Comment 3

[Ethan Hugg [:ehugg]]

Attachment: Unused methods removed from CC_Call

Comment 4

[Ethan Hugg [:ehugg]]

Comment on attachment 667618 [details] [diff] [review]
Unused methods removed from CC_Call


First patch was over-zealous with the trailing whitespace removal.

Comment 5

[Ethan Hugg [:ehugg]]

Comment on attachment 667618 [details] [diff] [review]
Unused methods removed from CC_Call


Pushed to Alder - http://hg.mozilla.org/projects/alder/rev/27a4c0c98966