797213 - Various jstests.py changes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

I made a collection of unrelated little changes to jstests.py

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: jstests.py: add a -F (--failed-only) option to only display output of failed tests.

I also snuck a change to the output format, to display the test name in the output so that it is possible to associate output with the test that produced it. I mixed it in just because it was a little harder to separate out into a separate patch. I could easily do so, if you'd like.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: jstests.py -O<filename> should default show-output to on.

I didn't expect to have to specify -o in addition to -O. I get that you might want to use -s instead of -o, but -o is probably much more common.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Test output may not go to stdout if -O given

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 667244 [details] [diff] [review]
jstests.py: add a -F (--failed-only) option to only display output of failed tests.

Review of attachment 667244 [details] [diff] [review]:
-----------------------------------------------------------------

Handy!

::: js/src/tests/jstests.py
@@ +113,5 @@
>                           help='Show exact commandline used to run each test.')
>      output_og.add_option('-o', '--show-output', action='store_true',
>                           help="Print each test's output to stdout.")
> +    output_og.add_option('-F', '--failed-only', action='store_true',
> +                         help="Only print output for failed tests.")

You might want to mention that this only filters --show-output and --show-output is still required to get any test output.

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 667245 [details] [diff] [review]
jstests.py -O<filename> should default show-output to on.

Review of attachment 667245 [details] [diff] [review]:
-----------------------------------------------------------------

Okay by me.

Comment 6

[Terrence Cole [:terrence]]

Comment on attachment 667246 [details] [diff] [review]
Test output may not go to stdout if -O given

Review of attachment 667246 [details] [diff] [review]:
-----------------------------------------------------------------

I'm guessing this belongs on top of the prior patch ;-).

::: js/src/tests/jstests.py
@@ +111,5 @@
>      output_og = OptionGroup(op, "Output", "Modify the harness and tests output.")
>      output_og.add_option('-s', '--show-cmd', action='store_true',
>                           help='Show exact commandline used to run each test.')
>      output_og.add_option('-o', '--show-output', action='store_true',
> +                         help="Print each test's output.")

s/output./output to the file specified by --output-file./

@@ +116,4 @@
>      output_og.add_option('-F', '--failed-only', action='store_true',
>                           help="Only print output for failed tests.")
>      output_og.add_option('-O', '--output-file',
>                           help='Write all output to the given file.')

Add: " (default: stdout)"

Comment 7

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a195554cc7f6
http://hg.mozilla.org/integration/mozilla-inbound/rev/a714b4f802e2
http://hg.mozilla.org/integration/mozilla-inbound/rev/5a932c059384

try push: https://tbpl.mozilla.org/?tree=Try&rev=4762cd73c124

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5a932c059384
https://hg.mozilla.org/mozilla-central/rev/a714b4f802e2
https://hg.mozilla.org/mozilla-central/rev/a195554cc7f6