79722 - nsDOMCSSDeclaration::GetCssText not implemented

Status: VERIFIED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

nsDOMCSSDeclaration::GetCssText is not implemented. The resolution of this bug is
needed for the CSSization of Composer.

Proposing easy fix below.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.0 for 79722

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Easy fix proposed for this bug. Already tested on win2k.

r= and sr= needed, please.

Comment 3

[Marc Attinasi]

I think you should leave the Truncate on the out-param in there
(aCssText.Truncate();), and change:

  NS_OK == result

to

  NS_SUCCEEDED(result)

With that, sr=attinasi

Comment 4

[harishd]

1) You can use nsCOMPtr.
2) I don't think that the "result" propagation is necessary ( unless 
GetCSSDeclaration has anything to do with the heap ).
3) Add NS_ASSERTION for decl.

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Marc   :  ok, I used the style of GetLength in same file
Harish :  1) use of nsCOMPtr : ok
          2) ok, I used the style of GetLength in same file
          3) assertion on decl : ok

Comment 6

[harishd]

Daniel, could you please attach the updated patch? Thanx

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.1

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

patch v1.1 attached in answer to Harish and Marc comments.

Comment 9

[harishd]

r=harishd

Comment 10

[Asa Dotzler [:asa]]

This morning's builds had a bug ( bug 80746 ) which may have led to 
a Bugzilla user inadvertantly 
changing this bug from the Assignbed/Accepted status to the New status.  If you 
are the owner of this bug please check to see that it is in the correct Status.  
Thanks.

Comment 11

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Re-marking correct status for this bug after Asa's comment.

Comment 12

[Johnny Stenback (:jst)]

The check:

  if (nsnull != decl) {
    ...
  }

doesn't work on all platforms, change it to:

  if (decl) {
    ...
  }

(which IMO makes more sense and is more readable, even if nsCOMPtr's aren't
involved)

Make that change and you'll have sr=jst.

Comment 13

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.2 in answer to jst

Comment 14

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

fixed and checked in :-)

Comment 15

[Hixie (not reading bugmail)]

Using
   http://www.hixie.ch/tests/ngdriver/domcss/scsd000.html
...verified that this works, for some definition of works. (As in, what we do
is within the range of possibilities allowed by the spec...)