Closed
Bug 79722
Opened 24 years ago
Closed 24 years ago
nsDOMCSSDeclaration::GetCssText not implemented
Categories
(Core :: DOM: CSS Object Model, defect, P3)
Core
DOM: CSS Object Model
Tracking
()
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: glazou, Assigned: glazou)
References
Details
Attachments
(3 files)
764 bytes,
patch
|
Details | Diff | Splinter Review | |
725 bytes,
patch
|
Details | Diff | Splinter Review | |
715 bytes,
patch
|
Details | Diff | Splinter Review |
nsDOMCSSDeclaration::GetCssText is not implemented. The resolution of this bug is
needed for the CSSization of Composer.
Proposing easy fix below.
Assignee | ||
Comment 1•24 years ago
|
||
Assignee | ||
Comment 2•24 years ago
|
||
Easy fix proposed for this bug. Already tested on win2k.
r= and sr= needed, please.
Blocks: 77705
Status: NEW → ASSIGNED
Comment 3•24 years ago
|
||
I think you should leave the Truncate on the out-param in there
(aCssText.Truncate();), and change:
NS_OK == result
to
NS_SUCCEEDED(result)
With that, sr=attinasi
1) You can use nsCOMPtr.
2) I don't think that the "result" propagation is necessary ( unless
GetCSSDeclaration has anything to do with the heap ).
3) Add NS_ASSERTION for decl.
Assignee | ||
Comment 5•24 years ago
|
||
Marc : ok, I used the style of GetLength in same file
Harish : 1) use of nsCOMPtr : ok
2) ok, I used the style of GetLength in same file
3) assertion on decl : ok
Updated•24 years ago
|
Priority: -- → P3
Target Milestone: --- → mozilla0.9.2
Assignee | ||
Comment 7•24 years ago
|
||
Assignee | ||
Comment 8•24 years ago
|
||
patch v1.1 attached in answer to Harish and Marc comments.
Comment 10•24 years ago
|
||
This morning's builds had a bug ( bug 80746 ) which may have led to
a Bugzilla user inadvertantly
changing this bug from the Assignbed/Accepted status to the New status. If you
are the owner of this bug please check to see that it is in the correct Status.
Thanks.
Assignee | ||
Comment 11•24 years ago
|
||
Re-marking correct status for this bug after Asa's comment.
Status: NEW → ASSIGNED
Comment 12•24 years ago
|
||
The check:
if (nsnull != decl) {
...
}
doesn't work on all platforms, change it to:
if (decl) {
...
}
(which IMO makes more sense and is more readable, even if nsCOMPtr's aren't
involved)
Make that change and you'll have sr=jst.
Assignee | ||
Comment 13•24 years ago
|
||
Assignee | ||
Comment 14•24 years ago
|
||
fixed and checked in :-)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 15•24 years ago
|
||
Using
http://www.hixie.ch/tests/ngdriver/domcss/scsd000.html
...verified that this works, for some definition of works. (As in, what we do
is within the range of possibilities allowed by the spec...)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•