Closed
Bug 797255
Opened 13 years ago
Closed 13 years ago
Add support for the layer attribute to nsImageBoxFrame
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.72 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
I'm not sure how this ever worked, I tested it too.
Attachment #667316 -
Flags: review?(roc)
Comment on attachment 667316 [details] [diff] [review]
Support layer attribute
Review of attachment 667316 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/xul/base/src/nsImageBoxFrame.cpp
@@ +309,5 @@
> + nsDisplayList list;
> + list.AppendNewToTop(new (aBuilder) nsDisplayXULImage(aBuilder, this));
> + return aLists.Content()->AppendNewToTop(new (aBuilder)
> + nsDisplayOwnLayer(aBuilder, this, &list));
> + }
Create a helper method nsFrame::CreateOwnLayerIfNeeded(nsDisplayListBuilder* aBuilder, nsDisplayList* aList)
so we can easily add more frame types to this later, if needed.
Then always create a new nsDisplayXULImage, put it in 'list', call CreateOwnLayerIfNeeded, and append the list to Content().
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #667316 -
Attachment is obsolete: true
Attachment #667316 -
Flags: review?(roc)
Attachment #669372 -
Flags: review?(roc)
Attachment #669372 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Assignee: nobody → matt.woodrow
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•