797291 - [E.me] New "Add to Home Screen" action to wrapper launching apps from e.me

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Cristian Rodriguez (:crdlc)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/537.4 (KHTML, like Gecko) Chrome/22.0.1229.79 Safari/537.4

Steps to reproduce:

Imagine grooveshark app is not available in the grid

1) User goes to ev.me
2) Search 'Madonna'
3) User clicks on grooveshark app
4) Wrapper loads grooveshark with Madonna's songs


Actual results:

Button bar doesn't show a star icon to show the action 'Add to Home Screen'


Expected results:

1) Button bar should show a generic "Star" icon like browser
2) User clicks on the star icon and a prompt of the system appears automatically saying: 'Add to Home Screen', Yes or No..
3) User wants to add to homescreen and clicks on 'Yes' button. Automatically, the new app is added to home but with the URL provided by the everything.me engine, in this case grooveshark entry point without specific Madonna search.
4) After adding the app the star disappears from button bar

Comment 1

[Cristian Rodriguez (:crdlc)]

This tak started here https://github.com/mozilla-b2g/gaia/issues/5392

Comment 2

[Josh Carpenter [:jcarpenter]]

> saying: 'Add to Home Screen', Yes or No..

Should say: "Add [AppName] to Home Screen?" ... "Cancel" or "Add"

Comment 3

[Cristian Rodriguez (:crdlc)]

ok, thanks

Comment 4

[Cristian Rodriguez (:crdlc)]

Coulb be "Cancel" and "OK" ? Because we are using the system confirm

Comment 5

[Cristian Rodriguez (:crdlc)]

done

https://github.com/mozilla-b2g/gaia/pull/5657

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Setting to resolved fixed from comment 5.  Need to verify in tomorrow's build.

Comment 7

[Josh Carpenter [:jcarpenter]]

> Coulb be "Cancel" and "OK" ? Because we are using the system confirm

Yes, that's fine.

It SUCKS for v1 that we can't do custom labels.  My UX colleagues are going to throw tomatoes at me for it. :(

Comment 8

[Josh Carpenter [:jcarpenter]]

> It SUCKS for v1 that we can't do custom labels.  My UX colleagues are going to throw tomatoes at me for it. :(

Sorry, to be clear, I meant it sucks system-wide. Not just in this case.  :)

Comment 9

[Cristian Rodriguez (:crdlc)]

jajjaaj I understand :)

Comment 10

[Cristian Rodriguez (:crdlc)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/5657

Comment 11

[Cristian Rodriguez (:crdlc)]

Attachment: I fixed the automatically merged

https://github.com/mozilla-b2g/gaia/pull/5657

Comment 12

[Cristian Rodriguez (:crdlc)]

Comment on attachment 669067 [details]
https://github.com/mozilla-b2g/gaia/pull/5657

obsoleted

Comment 13

[Cristian Rodriguez (:crdlc)]

Attachment: Add to Home Screen from evme

Furthermore, a bug has been fixed when you open a wrapper and close immediately the footer was open although the wrapper is background and the homescreen in foreground

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The patch has not yet landed. Re-opening.

Comment 15

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I have made some comments directly on github.

Comment 16

[Cristian Rodriguez (:crdlc)]

Attachment: Implemented suggestion from Vivien

Comment 17

[Cristian Rodriguez (:crdlc)]

Attachment: Implemented suggestions from Cazenave

Comment 18

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 669435 [details]
Implemented suggestions from Cazenave

Comments on github.

Comment 19

[Cristian Rodriguez (:crdlc)]

Attachment: Deleted confirmation

Comment 20

[Cristian Rodriguez (:crdlc)]

It was implemented one month ago