797300 - Skip pay provider selector in navigator.mozPay() when only one JWT

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

Since we are not solving this on the platform, this is the appropriate Gaia bug for Bug 793811.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 667413 [details] [diff] [review]
v1

Review of attachment 667413 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me :) just the lint question.

Thanks!

::: apps/system/js/payment.js
@@ +68,1 @@
>                                requests[i].productPrice[0].amount + ' ' +

is this code passing the linter?

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

(In reply to francisco.jordano from comment #2)
> Comment on attachment 667413 [details] [diff] [review]
> v1
> 
> Review of attachment 667413 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good to me :) just the lint question.
> 
> Thanks!
> 
> ::: apps/system/js/payment.js
> @@ +68,1 @@
> >                                requests[i].productPrice[0].amount + ' ' +
> 
> is this code passing the linter?

I don't know. I can't trigger the linter :\

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #3)
> (In reply to francisco.jordano from comment #2)
> > Comment on attachment 667413 [details] [diff] [review]
> > v1
> > 
> > Review of attachment 667413 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > Looks good to me :) just the lint question.
> > 
> > Thanks!
> > 
> > ::: apps/system/js/payment.js
> > @@ +68,1 @@
> > >                                requests[i].productPrice[0].amount + ' ' +
> > 
> > is this code passing the linter?
> 
> I don't know. I can't trigger the linter :\

I think you can `make lint` in your local working gaia directory?

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

I did that, thanks!
`make lint | grep payment` shows no error, so I'll go with the merge.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

r+ then

:)

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 667413 [details] [diff] [review]
v1

Thanks :). r+ based on the comment above.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/pull/5652

Comment 9

[Jason Smith [:jsmith]]

Verified on 10/11 Otoro build.