If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix -Werror=conversion-null errors in Windows-only code

RESOLVED FIXED in mozilla18

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla18
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(9 attachments)

(Assignee)

Description

5 years ago
Windows-only code was not fixed before landing bug 778980, because this warning is not supported by MSVC. They are errors when compiling with GCC/mingw.
(Assignee)

Comment 1

5 years ago
Created attachment 667414 [details] [diff] [review]
xpcom/threads part

Also fixes:

HangMonitor.cpp:311:9: warning: enumeration value ‘kGeneralActivity’ not handled in switch [-Wswitch]
Attachment #667414 - Flags: review?(ehsan)
(Assignee)

Comment 2

5 years ago
Created attachment 667418 [details] [diff] [review]
dom/plugins part

Also fixes:

NPEventWindows.h:101:81: warning: comparison is always true due to limited range of data type [-Wtype-limits]
nsPluginsDirWin.cpp:283:10: warning: unused variable ‘bCheck’ [-Wunused-variable]
nsPluginNativeWindowWin.cpp:697:29: warning: unused variable ‘win’ [-Wunused-variable]

and --disable-accessibility builds that failed in nsNPAPIPlugin::RunPluginOOP
Attachment #667418 - Flags: review?(surkov.alexander)
(Assignee)

Comment 3

5 years ago
Created attachment 667420 [details] [diff] [review]
embedding/components/printingui part

Also fixes:

nsPrintingPromptService.cpp:99:10: warning: unused variable ‘hWnd’ [-Wunused-variable]
nsPrintingPromptService.cpp:45:18: warning: ‘gInstance’ defined but not used [-Wunused-variable]
Attachment #667420 - Flags: review?(ehsan)
(Assignee)

Comment 4

5 years ago
Created attachment 667421 [details] [diff] [review]
gfx/gl part

Also fixes:

GLContextProviderWGL.cpp:506:14: warning: variable ‘isCurrent’ set but not used [-Wunused-but-set-variable]
Attachment #667421 - Flags: review?(bjacob)
(Assignee)

Comment 5

5 years ago
Created attachment 667423 [details] [diff] [review]
gfx/thebes part

Also fixes a few set but unused variables and:

gfxGDIFontList.cpp:284:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Attachment #667423 - Flags: review?(jmuizelaar)
(Assignee)

Comment 6

5 years ago
Created attachment 667429 [details] [diff] [review]
ipc/ part

Also fixes:

SyncChannel.h:166:13: warning: ‘mozilla::ipc::SyncChannel::mTimeoutMs’ will be initialized after [-Wreorder]
SyncChannel.h:100:21: warning:   ‘mozilla::ipc::SyncChannel::SyncStackFrame* mozilla::ipc::SyncChannel::mTopFrame’ [-Wreorder]
SyncChannel.cpp:27:1: warning:   when initialized here [-Wreorder]

SyncChannel.cpp:91:13: warning: unused variable ‘msgSeqno’ [-Wunused-variable]
WindowsMessageLoop.cpp:466:14: warning: unused variable ‘currentWndProc’ [-Wunused-variable]
WindowsMessageLoop.cpp:95:5: warning: ‘{anonymous}::gEventLoopDepth’ defined but not used [-Wunused-variable]
Attachment #667429 - Flags: review?(jones.chris.g)
(Assignee)

Comment 7

5 years ago
Created attachment 667432 [details] [diff] [review]
toolkit/components/parentalcontrols part

Also fixes -Wreorder warning
Attachment #667432 - Flags: review?(netzen)
(Assignee)

Comment 8

5 years ago
Created attachment 667433 [details] [diff] [review]
uriloader part

Also fixes:

nsMIMEInfoWin.cpp:823:3: warning: multi-line comment [-Wcomment]

and a few similar ones.
Attachment #667433 - Flags: review?(justin.lebar+bug)
Attachment #667432 - Flags: review?(netzen) → review+
(Assignee)

Comment 9

5 years ago
Created attachment 667435 [details] [diff] [review]
widget/windows part
Attachment #667435 - Flags: review?(cpearce)
(In reply to Jacek Caban from comment #6)
> Created attachment 667429 [details] [diff] [review]
> SyncChannel.cpp:91:13: warning: unused variable ‘msgSeqno’
> [-Wunused-variable]

Fixed in bug 797111.

Updated

5 years ago
Attachment #667414 - Flags: review?(ehsan) → review+

Updated

5 years ago
Attachment #667420 - Flags: review?(ehsan) → review+
Comment on attachment 667433 [details] [diff] [review]
uriloader part

I'm not sure why I was tagged to review this, but it looks fine to me.  Damn Windows and backslashes in paths...
Attachment #667433 - Flags: review?(justin.lebar+bug) → review+
(In reply to Jacek Caban from comment #0)
> Windows-only code was not fixed before landing bug 778980, because this
> warning is not supported by MSVC. They are errors when compiling with
> GCC/mingw.

Thanks for fixing these, Jacek. If Windows GCC/mingw builds were part of the tinderbox/try server, I would have caught them. <:)
Attachment #667423 - Flags: review?(jmuizelaar) → review+
Comment on attachment 667429 [details] [diff] [review]
ipc/ part

bent is a better reviewer for the win32 code here.
Attachment #667429 - Flags: review?(jones.chris.g) → review?(bent.mozilla)
Comment on attachment 667435 [details] [diff] [review]
widget/windows part

I think this is more Jimm's area than mine.
Attachment #667435 - Flags: review?(cpearce) → review?(jmathies)
Attachment #667429 - Flags: review?(bent.mozilla) → review+

Comment 15

5 years ago
Comment on attachment 667435 [details] [diff] [review]
widget/windows part

Builds ok w/msvc. Thanks for the patches!
Attachment #667435 - Flags: review?(jmathies) → review+

Comment 16

5 years ago
Comment on attachment 667418 [details] [diff] [review]
dom/plugins part

I'm not plugin module peer, redirecting request to Josh
Attachment #667418 - Flags: review?(surkov.alexander) → review?(joshmoz)
Comment on attachment 667421 [details] [diff] [review]
gfx/gl part

Review of attachment 667421 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #667421 - Flags: review?(bjacob) → review+

Updated

5 years ago
Attachment #667418 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 18

5 years ago
Thanks for all reviews.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d2aec62e155
https://hg.mozilla.org/integration/mozilla-inbound/rev/64ac66fde0af
https://hg.mozilla.org/integration/mozilla-inbound/rev/37046745e742
https://hg.mozilla.org/integration/mozilla-inbound/rev/8913d486d3f4
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a5f910c446
https://hg.mozilla.org/integration/mozilla-inbound/rev/65b1536aee04
https://hg.mozilla.org/integration/mozilla-inbound/rev/aaefd3bb4dba
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd36f348362b
https://hg.mozilla.org/integration/mozilla-inbound/rev/1415aa5411b1
(In reply to Chris Peterson (:cpeterson) from comment #12)
> Thanks for fixing these, Jacek. If Windows GCC/mingw builds were part of the
> tinderbox/try server, I would have caught them. <:)

mingw builds are Tier 3, so this is an acceptable state of affairs.
https://hg.mozilla.org/mozilla-central/rev/5d2aec62e155
https://hg.mozilla.org/mozilla-central/rev/64ac66fde0af
https://hg.mozilla.org/mozilla-central/rev/37046745e742
https://hg.mozilla.org/mozilla-central/rev/8913d486d3f4
https://hg.mozilla.org/mozilla-central/rev/d4a5f910c446
https://hg.mozilla.org/mozilla-central/rev/65b1536aee04
https://hg.mozilla.org/mozilla-central/rev/aaefd3bb4dba
https://hg.mozilla.org/mozilla-central/rev/bd36f348362b
https://hg.mozilla.org/mozilla-central/rev/1415aa5411b1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.