'Build' and 'test run' filter captions aren't immediately obvious

RESOLVED FIXED

Status

Tree Management
OrangeFactor
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
On the main OrangeFactor bug table/graph view, there are three dropdowns for filtering:
* platform
* build
* test run

Platform is obvious, however 'build' and 'test run', imply to me something more like filtering by push/build-id/revision etc rather than 'build type' (pgo/debug/opt) and 'test suite' (reftest,mochitest,...).
(Assignee)

Comment 1

6 years ago
(For 'test run': Particularly since we use "test run count" as a caption in the graph to refer to number of pushes; rather than the test suite)
(Assignee)

Comment 2

6 years ago
Created attachment 667419 [details] [diff] [review]
Patch v1

* s/build/build type/
* s/test run/test suite/
Attachment #667419 - Flags: review?(mcote)
(Assignee)

Comment 3

6 years ago
Created attachment 667882 [details] [diff] [review]
Patch v2

Also changes the bug details table column caption from "Test" to "Test Suite".
Attachment #667419 - Attachment is obsolete: true
Attachment #667419 - Flags: review?(mcote)
Attachment #667882 - Flags: review?(mcote)

Comment 4

6 years ago
Comment on attachment 667882 [details] [diff] [review]
Patch v2

Review of attachment 667882 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but can you also update the dropdown on the Bug Count view?
Attachment #667882 - Flags: review?(mcote) → review+
(Assignee)

Comment 5

6 years ago
(In reply to Mark Côté ( :mcote ) from comment #4)
> Looks good but can you also update the dropdown on the Bug Count view?

I think we discussed this on IRC at the time, but recording here for posterity. The dropdowns are generated from the dataset, so it's not a simple substitution, so isn't worth the time:reward at the moment, given the years of sheriffing maintenance defficit on TBPL et al.

Landed the attached patch to get this bug out of my assigned bugs query":
http://hg.mozilla.org/automation/orangefactor/rev/d0474b5c2876

And I'll file a followup to make the bug count view change.
(Assignee)

Updated

6 years ago
Blocks: 834708
(Assignee)

Comment 6

6 years ago
Needs deploying, but can wait for next push :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Testing → Tree Management
You need to log in before you can comment on or make changes to this bug.