797349 - Save originating URI in GIO for downloaded files

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Jan Horak [:jhorak]]

From https://bugzilla.redhat.com/show_bug.cgi?id=862269 :


It would be nice if firefox could save the original uri for downloaded files.
This is pretty easy to do with GIO using gvfs metadata. I implemented this in
webkit:

https://bugs.webkit.org/show_bug.cgi?id=95188

Its a pretty trivial patch, so it should be easy to add to firefox too.

We want to use this to e.g. show the original location in the download directory in nautilus.

Comment 1

[Jan Horak [:jhorak]]

Attachment: Save uri for downloaded files patch v1

Please have a look.

Comment 2

[[e-mail]]

Comment on attachment 667478 [details] [diff] [review]
Save uri for downloaded files patch v1

Sadly there isn't enough context to show this but you have added your code in a path used only when the "add to recent documents" preference is enabled.

>+                                   (gpointer)source_uri.BeginReading(),
Use .get() when you want a null-terminated string. (Use BeginReading() when you have a const nsACString& and don't need it to be null-terminated.)

Comment 3

[Jan Horak [:jhorak]]

Attachment: Save uri for downloaded files patch v2

Posting fixed patch. Thanks for quick review.

Comment 4

[Alexander Larsson]

+          gchar* uri = g_filename_to_uri(NS_ConvertUTF16toUTF8(path).get(),
+                                         NULL, NULL);
+          GFile* gio_file = g_file_new_for_uri(uri);

Why not use g_file_new_for_path() instead?

Comment 5

[Jan Horak [:jhorak]]

Attachment: Save uri for downloaded files patch v3

(In reply to Alexander Larsson from comment #4)
> +          gchar* uri = g_filename_to_uri(NS_ConvertUTF16toUTF8(path).get(),
> +                                         NULL, NULL);
> +          GFile* gio_file = g_file_new_for_uri(uri);
> 
> Why not use g_file_new_for_path() instead?
Okay, looks better, thanks.

Comment 6

[[e-mail]]

(In reply to jhorak from comment #0)
> We want to use this to e.g. show the original location in the download
> directory in nautilus.

So, Nautilus doesn't do that yet? How can I verify that the patch works?

Comment 7

[Jan Horak [:jhorak]]

(In reply to [e-mail] from comment #6)
> (In reply to jhorak from comment #0)
> > We want to use this to e.g. show the original location in the download
> > directory in nautilus.
> 
> So, Nautilus doesn't do that yet? How can I verify that the patch works?
From http://blogs.gnome.org/alexl/category/gio/
something like: gvfs-info -a "metadata::*" downloaded_file

Comment 8

[Alexander Larsson]

Yeah, that should work.

Comment 9

[[e-mail]]

Comment on attachment 667888 [details] [diff] [review]
Save uri for downloaded files patch v3

$ gvfs-info -a "metadata::*" ~/Downloads/comm-central_fedora-debug_test-xpcshell-bm18-tests1-linux-build259.txt.gz
attributes:
  metadata::download-uri: http://ftp.mozilla.org/pub/mozilla.org/thunderbird/tinderbox-builds/comm-central-linux-debug/1349387487/comm-central_fedora-debug_test-xpcshell-bm18-tests1-linux-build259.txt.gz
  metadata::nautilus-icon-position: 
  metadata::screen: 

>+          // Storing source URI for later display in file manager by using GIO
Nit: possible slight improvement to comment grammar:
// Use GIO to store the source URI for later display in the file manager.

Comment 10

[Jan Horak [:jhorak]]

Attachment: Save uri for downloaded files patch v4

Fixed grammar, review+ from previous comment. Thanks.

Comment 11

[Matthew N. [:MattN]]

Pushed to try server for testing: https://tbpl.mozilla.org/?tree=Try&rev=e57970061793

I'll push to inbound if all goes well.

Comment 12

[Matthew N. [:MattN]]

Comment on attachment 669050 [details] [diff] [review]
Save uri for downloaded files patch v4

https://hg.mozilla.org/integration/mozilla-inbound/rev/0008531f1429

Thanks! In the future, please include the bug number and reviewer in the commit messages. See https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Commit_message_restrictions

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0008531f1429