797363 - Remove aol.com user agent override since mail.aol.com is fixed

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 667962 [details] [diff] [review]
patch

Can you make the initialization of UserAgentOverrides conditional on the presence of general.useragent.override.* prefs, rather than commenting them out like that?

How did you determine that this was fixed?

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #2)
> How did you determine that this was fixed?

Look here
https://bugzilla.mozilla.org/show_bug.cgi?id=778408#c16

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #2)
> Comment on attachment 667962 [details] [diff] [review]
> patch
> 
> Can you make the initialization of UserAgentOverrides conditional on the
> presence of general.useragent.override.* prefs, rather than commenting them
> out like that?

Where? In nsBrowserGlue? In the jsm? Initializing the module without any prefs set is a reasonable thing to do, since the module will monitor the pref branch for live modifications. I just thought we'd rather avoid the tiny overhead, but other consumers might decide differently.

> How did you determine that this was fixed?

I logged in with a dummy AOL mail account.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to Dão Gottwald [:dao] from comment #4)
> Where? In nsBrowserGlue? In the jsm? Initializing the module without any
> prefs set is a reasonable thing to do, since the module will monitor the
> pref branch for live modifications. I just thought we'd rather avoid the
> tiny overhead, but other consumers might decide differently.

I meant in nsBrowserGlue. I don't think we need to support live modifications to these prefs at all, really.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch

This override isn't the last one anymore, so I'm simply removing the pref and leaving the initialization alone.

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a55eb145a21

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4a55eb145a21

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 669936 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 778408 (tech evangelism made this override unnecessary)
User impact if declined: we expect AOL mail to work either way
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 10

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6c938992407a
https://hg.mozilla.org/releases/mozilla-beta/rev/608df791629c