The default bug view has changed. See this FAQ.

Blacklist ibm864 converter

RESOLVED FIXED in mozilla19

Status

()

Core
Internationalization
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

(Blocks: 1 bug)

unspecified
mozilla19
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Our current mapping is based on the Unicode.org table + euro sign. It is bad especially because it has incompatible with ASCII (0x25 to U+0664).
(Assignee)

Comment 1

5 years ago
If w3c bugzilla 19250 has been fixed, we'll stop exposing ibm864 to the Web. If it is wontfixed, we'll update the mapping.
(Assignee)

Updated

5 years ago
Blocks: 746911
(Assignee)

Comment 2

5 years ago
ibm864 has been removed from the spec.
Summary: Blacklist or fix ibm864 converter → Blacklist ibm864 converter
(Assignee)

Comment 3

5 years ago
Created attachment 668764 [details] [diff] [review]
Part 1: rename isXSSVlunerable flag to isInternal and add the flag to ibm864

I renamed the flag because a flagged value is not always vulnerable to XSS anymore.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #668764 - Flags: review?(smontagu)
(Assignee)

Comment 4

5 years ago
Created attachment 668765 [details] [diff] [review]
Part 2: Remove ibm864 usage
Attachment #668765 - Flags: review?(smontagu)
(Assignee)

Comment 5

5 years ago
Created attachment 668766 [details] [diff] [review]
Part 3: Remove ibm864i converter

Ibm864i is our internal name solely for representing "logical" ibm864. It has no useful purpose anymore.
Attachment #668766 - Flags: review?(smontagu)
What are we using the decoder for? Why flag it instead of completely removing it?
(In reply to Henri Sivonen (:hsivonen) from comment #6)
> What are we using the decoder for? Why flag it instead of completely
> removing it?

Nevermind. Part 1 confused me.
Attachment #668764 - Flags: review?(smontagu) → review+
Attachment #668765 - Flags: review?(smontagu) → review+
Comment on attachment 668766 [details] [diff] [review]
Part 3: Remove ibm864i converter

Review of attachment 668766 [details] [diff] [review]:
-----------------------------------------------------------------

Please remove intl/uconv/ucvibm/864i.uf intl/uconv/ucvibm/864i.uf and 864i.ut also.
Attachment #668766 - Flags: review?(smontagu) → review+
(Assignee)

Comment 9

5 years ago
Created attachment 669614 [details] [diff] [review]
Part 3: Remove ibm864i converter. r=smontagu

patch for checkin
Attachment #668766 - Attachment is obsolete: true
Attachment #669614 - Flags: review+
(Assignee)

Comment 10

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=32642aa48750
Linux opt Moth failure seems to be unrelated to this patch.
Keywords: checkin-needed
(Assignee)

Comment 11

5 years ago
(In reply to Masatoshi Kimura [:emk] from comment #10)
> https://tbpl.mozilla.org/?tree=Try&rev=32642aa48750
> Linux opt Moth failure seems to be unrelated to this patch.
It looks like bug 798849.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bafdb575a2e
https://hg.mozilla.org/integration/mozilla-inbound/rev/01cf77723b86
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d0ae7bc88ae
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3bafdb575a2e
https://hg.mozilla.org/mozilla-central/rev/01cf77723b86
https://hg.mozilla.org/mozilla-central/rev/8d0ae7bc88ae
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Created attachment 671782 [details] [diff] [review]
Fix Composer Save As Charset

Editor uses NC:EncodersRoot which discovered an IBM864 encoder. As it wasn't marked as not for outgoing it tried to find a title for it. However bug 777292 accidentally made a missing charset title fatal, so the encoders list is empty.

I assume that we shouldn't be suggesting the IBM864 encoder in the first place.
Attachment #671782 - Flags: review?
Attachment #671782 - Flags: feedback?(VYV03354)

Updated

5 years ago
Attachment #671782 - Flags: review? → review?(smontagu)
(Assignee)

Updated

5 years ago
Attachment #671782 - Flags: feedback?(VYV03354) → feedback+
Attachment #671782 - Flags: review?(smontagu) → review+
Comment on attachment 671782 [details] [diff] [review]
Fix Composer Save As Charset

Pushed mozilla-central changeset 8f702f78a929.
You need to log in before you can comment on or make changes to this bug.