Closed Bug 797385 Opened 12 years ago Closed 12 years ago

Blacklist ibm864 converter

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19

People

(Reporter: emk, Assigned: emk)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

Part 1: rename isXSSVlunerable flag to isInternal and add the flag to ibm864
6.81 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
Part 2: Remove ibm864 usage
16.40 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
Part 3: Remove ibm864i converter. r=smontagu
30.75 KB, patch
emk
: review+
Details | Diff | Splinter Review
Fix Composer Save As Charset
969 bytes, patch
smontagu
: review+
emk
: feedback+
Details | Diff | Splinter Review
Our current mapping is based on the Unicode.org table + euro sign. It is bad especially because it has incompatible with ASCII (0x25 to U+0664).
If w3c bugzilla 19250 has been fixed, we'll stop exposing ibm864 to the Web. If it is wontfixed, we'll update the mapping.
See Also: → https://www.w3.org/Bugs/Public/show_bug.cgi?id=19250
Blocks: encoding
ibm864 has been removed from the spec.
Summary: Blacklist or fix ibm864 converter → Blacklist ibm864 converter
I renamed the flag because a flagged value is not always vulnerable to XSS anymore.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #668764 - Flags: review?(smontagu)
Attachment #668765 - Flags: review?(smontagu)
Attached patch Part 3: Remove ibm864i converter (obsolete) — — Splinter Review
Ibm864i is our internal name solely for representing "logical" ibm864. It has no useful purpose anymore.
Attachment #668766 - Flags: review?(smontagu)
What are we using the decoder for? Why flag it instead of completely removing it?
(In reply to Henri Sivonen (:hsivonen) from comment #6) > What are we using the decoder for? Why flag it instead of completely > removing it? Nevermind. Part 1 confused me.
Attachment #668764 - Flags: review?(smontagu) → review+
Attachment #668765 - Flags: review?(smontagu) → review+
Comment on attachment 668766 [details] [diff] [review] Part 3: Remove ibm864i converter Review of attachment 668766 [details] [diff] [review]: ----------------------------------------------------------------- Please remove intl/uconv/ucvibm/864i.uf intl/uconv/ucvibm/864i.uf and 864i.ut also.
Attachment #668766 - Flags: review?(smontagu) → review+
patch for checkin
Attachment #668766 - Attachment is obsolete: true
Attachment #669614 - Flags: review+
https://tbpl.mozilla.org/?tree=Try&rev=32642aa48750 Linux opt Moth failure seems to be unrelated to this patch.
Keywords: checkin-needed
(In reply to Masatoshi Kimura [:emk] from comment #10) > https://tbpl.mozilla.org/?tree=Try&rev=32642aa48750 > Linux opt Moth failure seems to be unrelated to this patch. It looks like bug 798849.
Editor uses NC:EncodersRoot which discovered an IBM864 encoder. As it wasn't marked as not for outgoing it tried to find a title for it. However bug 777292 accidentally made a missing charset title fatal, so the encoders list is empty. I assume that we shouldn't be suggesting the IBM864 encoder in the first place.
Attachment #671782 - Flags: review?
Attachment #671782 - Flags: feedback?(VYV03354)
Attachment #671782 - Flags: review? → review?(smontagu)
Attachment #671782 - Flags: feedback?(VYV03354) → feedback+
Attachment #671782 - Flags: review?(smontagu) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: