Closed
Bug 797393
Opened 12 years ago
Closed 12 years ago
FrameMetrics == operator is broken
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: cwiiis, Assigned: cwiiis)
References
Details
Attachments
(1 file)
1.46 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
At some point, someone changed the FrameMetrics == operator to not check the resolution. Or perhaps it was always broken, but some other element of it has stopped changing at the same time as resolution. Anyway, this breaks retained tiles on Firefox Mobile on Android and makes it quite hard to do a few other things too - If for whatever reason there needs to be a FrameMetrics comparison that doesn't actually compare all aspects of the FrameMetrics, that should be an exception and documented.
Attaching a patch that fixes this, which also fixes rendering glitches when changing zoom levels in Firefox Mobile on Android.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
Makes the == operator compare each value in FrameMetrics, which fixes the metrics not updating when the resolution changes.
Attachment #667524 -
Flags: review?(roc)
Comment 3•12 years ago
|
||
Confirmed that this fixes my problem.
Comment on attachment 667524 [details] [diff] [review]
Fix FrameMetrics == operator
Review of attachment 667524 [details] [diff] [review]:
-----------------------------------------------------------------
The outermost parentheses are useless. Remove them.
Attachment #667524 -
Flags: review?(roc) → review+
Comment 5•12 years ago
|
||
Fixed and pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a34413a18f6
Target Milestone: --- → mozilla18
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•