797393 - FrameMetrics == operator is broken

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Lord [:cwiiis]]

At some point, someone changed the FrameMetrics == operator to not check the resolution. Or perhaps it was always broken, but some other element of it has stopped changing at the same time as resolution. Anyway, this breaks retained tiles on Firefox Mobile on Android and makes it quite hard to do a few other things too - If for whatever reason there needs to be a FrameMetrics comparison that doesn't actually compare all aspects of the FrameMetrics, that should be an exception and documented.

Attaching  a patch that fixes this, which also fixes rendering glitches when changing zoom levels in Firefox Mobile on Android.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Fix FrameMetrics == operator

Makes the == operator compare each value in FrameMetrics, which fixes the metrics not updating when the resolution changes.

Comment 3

[Benoit Girard (:BenWa)]

Confirmed that this fixes my problem.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 667524 [details] [diff] [review]
Fix FrameMetrics == operator

Review of attachment 667524 [details] [diff] [review]:
-----------------------------------------------------------------

The outermost parentheses are useless. Remove them.

Comment 5

[Benoit Girard (:BenWa)]

Fixed and pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a34413a18f6

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1a34413a18f6