797431 - Black clipping on resize with lightweight theme installed

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Rob Campbell [:rc] (:robcee)]

when resizing the browser with a lightweight theme applied, resizing is very slow to redraw, will not repaint toolbars at the bottom of the screen if made smaller until after resize is complete and will draw black clipped areas outside of content if the window is made larger.

OS X 10.8.2, nightly builds 2012-10-01 to 03.

Comment 1

[Benoit Girard (:BenWa)]

Confirmed, this happens if-and-only-if you have a lightweight theme (personas) installed.

This is similar to a bug we've fixed before but I can't find the number.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

What's the difference between a "lightweight" theme and a "regular" theme?

Please provide examples of both.

Comment 3

[Benoit Girard (:BenWa)]

We renamed personas to lightweight theme because we're releasing something else as peronas. There is no regular theme, we just mean the old term for personas here.

Comment 4

[Benoit Girard (:BenWa)]

Last good nightly: 2012-08-13
First bad nightly: 2012-08-14

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f89feda9d997&tochange=22288130fea2

Looks like it caused by DLBI. We likely have to do a fix like in bug 782980. Matt can you take a look?

Comment 6

[Matt Woodrow (:mattwoodrow)]

Oh right, that regression range doesn't include DBLI, just a bunch of preliminary work from a while ago.

This is more or less exactly the same as bug 782980.

The problem here is that we paint the same view twice, once for the titlebar, and once for the window. We set the 'force synchronous repaint' flag on resize, and it's used when painting the titlebar and cleared before we paint the window.

We need to make sure that the synchronous repaint happens for both paints of the view to get correct behaviour, not really sure what the best way to handle that is.

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Add alternate paint flags

Does this look like a reasonable approach?

Probably want to change the bool parameter crazyness into flags.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 670677 [details] [diff] [review]
Add alternate paint flags

Review of attachment 670677 [details] [diff] [review]:
-----------------------------------------------------------------

yes, flags, oh yes

Comment 9

[Matt Woodrow (:mattwoodrow)]

Attachment: Add flags to PaintWindow

Comment 10

[Matt Woodrow (:mattwoodrow)]

Attachment: Add alternate paint flags v2

Comment 11

[Matt Woodrow (:mattwoodrow)]

https://tbpl.mozilla.org/?tree=Try&rev=8ef7c0e0f031

Comment 12

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab00790e8fed
https://hg.mozilla.org/integration/mozilla-inbound/rev/1bca31fd0e58

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ab00790e8fed
https://hg.mozilla.org/mozilla-central/rev/1bca31fd0e58