Closed Bug 797435 Opened 7 years ago Closed 7 years ago

IonMonkey: Add rooting of IC stub IonCodes to OOL exit frames for callouts from those stubs.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: djvj, Unassigned)

References

Details

Attachments

(1 file)

This is needed so that IC stubs don't get collected when they're on the stack.  The OOLJSNativeGetterExitFrame and OOLPropertyOpExitFrame types need an extra field containing the IonCode they're executing under, so we can mark them during scanning.
Blocks: 786126
Some minor additional cleanup on top of just adding the stubCode field:  OOLNativeGetterExitFrames were marking the |this| value (target of the getprop) by just offsetting off of the |vp| value.  Added an explicit method to retrieve the |this| pointer for marking, and changed marking code to do that.
Attachment #667567 - Flags: review?(dvander)
Attachment #667567 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/1f6b48dea5fc
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.