IonMonkey: Add rooting of IC stub IonCodes to OOL exit frames for callouts from those stubs.

RESOLVED FIXED in mozilla18

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: djvj, Unassigned)

Tracking

unspecified
mozilla18
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
This is needed so that IC stubs don't get collected when they're on the stack.  The OOLJSNativeGetterExitFrame and OOLPropertyOpExitFrame types need an extra field containing the IonCode they're executing under, so we can mark them during scanning.
(Reporter)

Updated

6 years ago
Blocks: 786126
(Reporter)

Comment 1

6 years ago
Created attachment 667567 [details] [diff] [review]
Add stub IonCode pointer to OOL exit frames.

Some minor additional cleanup on top of just adding the stubCode field:  OOLNativeGetterExitFrames were marking the |this| value (target of the getprop) by just offsetting off of the |vp| value.  Added an explicit method to retrieve the |this| pointer for marking, and changed marking code to do that.
Attachment #667567 - Flags: review?(dvander)
Attachment #667567 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/1f6b48dea5fc
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.