797510 - ###!!! ASSERTION: hmm? CanCallNow failed in XPCWrappedNative::CallMethod.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Gregor Wagner [:gwagner]]

During b2g startup:

###!!! ASSERTION: hmm? CanCallNow failed in XPCWrappedNative::CallMethod. We are finding out about this late!: 'rv == NS_ERROR_XPC_SECURITY_MANAGER_VETO', file /Users/idefix2/code/gaia/isrc/js/xpconnect/src/XPCWrappedNative.cpp, line 2367
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component does not have requested interface [nsISettingsServiceCallback.handle]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/SettingsService.js :: <TOP_LEVEL> :: line 87"  data: no]
************************************************************

Comment 1

[Kent James (:rkent)]

This issue is also mentioned in bug 626893, bug 604312, and bug 490984. I don't know enough about the underlying XPConnect code to comment on root causes or set dups, but I was getting killed by this and I think I know how to fix it in the calling code.

I started getting this error when I modified some code in my complex binary Thunderbird extension so that a javascript driver routine for XHR actions was converted from a model of simple listener callbacks, to one where the callbacks are managed by a js generator implementing an async framework. So at least in my case the problem might be related to use of generators.

But I found that the callbacks methods where the error was occurring were missing QueryInterface results for the requested interface (one had no QI, the other had a QI but did not list the needed interface).

When I added correct QIs in the javascript methods, the problem went away (or so I hope, it is intermittent only occurring about 25% of the time).

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

I'll take a look at this bug.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Bug 797510 - add QI for DOMFMRadioParent

DOMFMRadioParent doesn't provide correct QueryInterface, therefore, XPConnect cannot determine whether callback object has |handle| method or not.
I found DOMFMRadioParent registers itself as a nsISettinsServiceCallback and a nsIObserver, so we need to declare both interfaces in QI.

Comment 4

[Justin Lebar (not reading bugmail)]

Comment on attachment 669879 [details] [diff] [review]
Bug 797510 - add QI for DOMFMRadioParent

Sure!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/887b293a2fd3

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/887b293a2fd3

Comment 7

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/260438f23bc1

Comment 8

[Justin Lebar (not reading bugmail)]

edmorley, do you have guidance as to whether I should be setting status-firefox19 to fixed as well?

Comment 9

[Ed Morley [:emorley]]

Only if security, or else tracking+ on trunk, aiui.