Closed Bug 797512 Opened 8 years ago Closed 8 years ago

Replace sstrncpy with snprintf in gsm_sdp.c in SIPCC

Categories

(Core :: WebRTC: Signaling, defect)

Product:
Core
Component:
WebRTC: Signaling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19
Tracking Flags:
Tracking Status
firefox18 --- wontfix

People

(Reporter: emannion, Assigned: ehugg)

Details

(Whiteboard: [WebRTC] [blocking-webrtc-] [qa-])

Attachments

(1 file)

Signaling: simplify set_dtls_fingerprint
1.50 KB, patch
jesup
: review+
jesup
: checkin+
Details | Diff | Splinter Review 
Replace instances of sstrncpy with snprintf in gsmsdp_set_dtls_fingerprint_attribute

This is from review comments.

Issue 10002: Rollup of SIPCC changes: gsm
Whiteboard: [WebRTC] [blocking-webrtc-]
Assignee: nobody → ethanhugg
Attachment #674055 - Flags: review?(rjesup)
Comment on attachment 674055 [details] [diff] [review]
Signaling: simplify set_dtls_fingerprint

Review of attachment 674055 [details] [diff] [review]:
-----------------------------------------------------------------

wow, is that simpler... :-)
Attachment #674055 - Flags: review?(rjesup) → review+
Attachment #674055 - Flags: checkin?(rjesup)
https://hg.mozilla.org/integration/mozilla-inbound/rev/f10906c2a705
status-firefox18: --- → wontfix
status-firefox19: --- → affected
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla19
Attachment #674055 - Flags: checkin?(rjesup) → checkin+
https://hg.mozilla.org/mozilla-central/rev/f10906c2a705
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-] [qa-]
You need to log in before you can comment on or make changes to this bug.