79756 - LDAP Base scope doesn't work for autocompletion

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P2)

Description

[yulian chang]

2001050904 build

Base scope doesn't work for autocompletion. "one Level" scope
works fine

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

The scope "base" would mean an addressbook with only a single address.  I was
thinking about this, and I find it pretty hard to imagine why someone would ever
want to use this, for autocomplete or otherwise (dunno why this didn't occur to
me when we were designing it).  Leif came up with one possible scenario, but
said it would be insanely rare and not a very good architecture besides.  So I'm
inclined to suggest that we just remove base from the URI entirely.  If someone
really really wants to do it, they could stilll edit prefs.js.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Er, remove it from the UI entirely, not the URI.

Comment 3

[Srilatha Moturi]

Or may be we can make one as default instead of base.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

One-level does sounds like a good default, but it seems like it would still make
sense to remove base if essentially noone is going to use it.

Comment 5

[Hong Kwon]

I agree with the assertion that adding UI that is easy to change and hard to
understand which has functionality breaking potential should be removed.

If we're very sure that no one has a use for Base Scope then it should be
removed.  Which also brings up the question, what is Subtree Scope for? 
Recursive queries?

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

No, it just tells the server what part of the LDAP tree to search.  Whether you
would use subtree or onelevel depends on the topology of the LDAP schema
deployed by your IS department.  Somewhere around here I probably have an LDAP
book that goes into more detail....

Comment 7

[Srilatha Moturi]

o.k will remove the base scope. will post a patch soon.

Comment 8

[Leif Hedstrom]

I'd strongly recommend using subtree search as the default. It's what a "normal"
user would expect from a search.

Very Poor Analogy(tm): You search a PacBell Phonebook, "one-level" search limits
you to the first page in each section (all the first A's, then the first B's
etc), while a subtree search would look at all pages. Clearly a user wants to
search the entire phonebook, not just one page in.

Subree is also the search done by default in all known Phonebook applications,
as well as Communicator 4.x (I'm pretty sure).

Comment 9

[Srilatha Moturi]

Attachment: removed base scope and made subtree as default

Comment 10

[Srilatha Moturi]

ccing Mohan for a review
ccing Seth for an sr

Comment 11

[Marek Z. Jeziorek]

Setting target milestone to 0.9.2 (check it in anytime, even before, when the
tree is open for). Per PDT triage.

Comment 12

[Srilatha Moturi]

Mohan can you review this. thanks

Comment 13

[Mohan Bhamidipati]

r=mohanb

Comment 14

[(not reading, please use [e-mail] instead)]

do you need to remove scopeBase.label from a dtd somewhere?

Comment 15

[Srilatha Moturi]

You are right. will updae the patch

Comment 16

[Srilatha Moturi]

Attachment: with scopeBase.label removed

Comment 17

[(not reading, please use [e-mail] instead)]

looks fine to me.  sr=sspitzer

Comment 18

[Srilatha Moturi]

Fix checked in

Comment 19

[yulian chang]

Verified with 2001052304 wins build