Closed Bug 797614 Opened 8 years ago Closed 8 years ago

Silence the warning about assignment in the condition in BasicTiledThebesLayer.cpp

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

BasicTiledThebesLayer.cpp
/Users/ehsanakhgari/moz/mozilla-central/gfx/layers/basic/BasicTiledThebesLayer.cpp:304:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      while (lastRect = it.Next()) {
             ~~~~~~~~~^~~~~~~~~~~
/Users/ehsanakhgari/moz/mozilla-central/gfx/layers/basic/BasicTiledThebesLayer.cpp:304:23: note: place parentheses around the assignment to silence this warning
      while (lastRect = it.Next()) {
                      ^
             (                   )
/Users/ehsanakhgari/moz/mozilla-central/gfx/layers/basic/BasicTiledThebesLayer.cpp:304:23: note: use '==' to turn this assignment into an equality comparison
      while (lastRect = it.Next()) {
                      ^
                      ==
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #667715 - Flags: review?(jmuizelaar)
Attachment #667715 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f51580af5a6
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/3f51580af5a6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.