797620 - Email: Message entry field is too small

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Mary Trombley]

Attachment: Pic of small text entry field in email

STR: Go to Compose Message screen in Email app

Expected: Message entry field should be larger than 1 line (see attachment). Font in message entry field seems unneccesarily small as well.

Actual: One small box with very tiny font (see attachment).

Build: 2012-09-18 10:21:32

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ya.  I probably should have reported this... I figured they weren't done tweaking the ui.  :|

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 667724 [details]
Pic of small text entry field in email

Indeed, I don't think we're really done with styling. The screenshot is just an all-white rectangle as far as I can make out so deprecating, but I assume we're talking about the body inputs as opposed to the subject which also is going to have size issues.

Right now, the compose textarea grows as you type stuff in using a broken heuristic that assumes the people typing stuff in are hitting enter when they type and not depending on the line-wrapping.  Its minimum size is 2 lines which is indeed nuts is way too small if the auto-grow heuristic isn't working, and arguably is too small in general, but I was trying to avoid triggering needless scrolling of the page until the time comes.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

I'm going to sort of declare bug 798695 to be the bug for doing actual fixing work since there are several birds related to the text-area we want to hit with that one stone, and we might as well discuss most of it in that place too.

Comment 4

[ayman maat :maat]

Hi Andrew

none of the attachments are still present for this bug so i cannot verify. So RFI to you to confirm this bug is valid or to close it is if it is not.

Thanks

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Sadly, the attachment was just an all-white image, so it was never useful.  But I'm not really sure why you would need it to reproduce.  The issue, as I understand it, is the hit target for the body text box.  Running the app in Firefox Nightly (see https://github.com/mozilla-b2g/gaia/blob/master/apps/email/README.md) I can use the developer tools' inspector and see that the body text box now has a min-height of 10em.  rows=1 is still happening, which means that the logic for setting that as described in bug 798695 has not changed.

In any event, 10rem is a pretty big hit area, so resolving WFM.

Comment 6

[ayman maat :maat]

thanks andrew