797672 - DeviceManagerSUT: listFiles('/') doesn't work

Status: RESOLVED DUPLICATE of bug 868505

(Testing :: Mozbase, defect)

Description

[Mark Côté [:mcote]]

DeviceManagerSUT.listFiles() does an rstrip('/') on the given path in order to remove any trailing slashes, but this turns '/' into '', which then fails the dirExists() call.

Comment 1

[Mark Côté [:mcote]]

Attachment: Normalize path in DeviceManagerSUT.listFiles() instead of just stripping slashes

We've agreed that paths accepted by SUT commands will be in POSIX format regardless of underlying OS, so we can just call posixpath.normpath() here, which removes trailing slashes on all but the root dir.

Comment 2

[William Lachance (:wlach)]

Comment on attachment 667793 [details] [diff] [review]
Normalize path in DeviceManagerSUT.listFiles() instead of just stripping slashes

LGTM

Comment 3

[Mark Côté [:mcote]]

So I'm 99.9% sure this won't break anything, but I'd like to run it through try first to be sure. I'll wait until the oranges are a bit more under control first, though.

Comment 4

[Mihnea Dobrescu-Balaur (:mihneadb)]

I think we should close this because of https://bugzilla.mozilla.org/show_bug.cgi?id=868505.