797786 - [b2g-bluetooth] Send a system message to notify 'progress updated'

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

As an indication, we need a system message to notify current file-sharing progress periodically.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: Send system message 'bluetooth-opp-update-progress'

* Send system message after processing every 50kb
* Use two parameters(proccessed file length, total file length) instead of one (percentage)

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 667878 [details] [diff] [review]
patch 1: v1: Send system message 'bluetooth-opp-update-progress'

Review of attachment 667878 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothOppManager.cpp
@@ +250,5 @@
>        if (mAbortFlag || mReadFileThread == nullptr) {
>          SendAbortRequest();
>        } else {
> +        // Sending system message "bluetooth-opp-update-progress" every 50kb,
> +        if (500000 * sUpdateProgressCounter < sSentFileLength) {

Nit: Turn magic number in a static const.

Comment 3

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: Send system message 'bluetooth-opp-update-progress', r=qdot

Nit picked.

Comment 4

[Eric Chou [:ericchou] [:echou]]

try:

https://tbpl.mozilla.org/?tree=Try&rev=500afb252122
https://tbpl.mozilla.org/?tree=Try&rev=086f7bd16b09

Comment 5

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/911be4e79787

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/911be4e79787