[b2g-bluetooth] Send a system message to notify 'progress updated'

RESOLVED FIXED in mozilla18

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: echou, Assigned: echou)

Tracking

unspecified
mozilla18
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(Whiteboard: [LOE:S])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
As an indication, we need a system message to notify current file-sharing progress periodically.
(Assignee)

Updated

6 years ago
Assignee: nobody → echou
Blocks: 792683
blocking-basecamp: --- → ?
Whiteboard: [LOE:S]
(Assignee)

Comment 1

6 years ago
Created attachment 667878 [details] [diff] [review]
patch 1: v1: Send system message 'bluetooth-opp-update-progress'

* Send system message after processing every 50kb
* Use two parameters(proccessed file length, total file length) instead of one (percentage)
Attachment #667878 - Flags: review?(kyle)
blocking-basecamp: ? → +
Comment on attachment 667878 [details] [diff] [review]
patch 1: v1: Send system message 'bluetooth-opp-update-progress'

Review of attachment 667878 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothOppManager.cpp
@@ +250,5 @@
>        if (mAbortFlag || mReadFileThread == nullptr) {
>          SendAbortRequest();
>        } else {
> +        // Sending system message "bluetooth-opp-update-progress" every 50kb,
> +        if (500000 * sUpdateProgressCounter < sSentFileLength) {

Nit: Turn magic number in a static const.
Attachment #667878 - Flags: review?(kyle) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 668287 [details] [diff] [review]
patch 1: v1: Send system message 'bluetooth-opp-update-progress', r=qdot

Nit picked.
Attachment #667878 - Attachment is obsolete: true

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/911be4e79787
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.