Closed Bug 797793 Opened 8 years ago Closed 8 years ago

Disable format warnings on mingw

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fix v1.0 (obsolete) — Splinter Review
format warnings are meant to avoid problems with printf-like functions. win32 format is not fully compatible with POSIX. On mingw GCC it's possible to specify which variant to use. However, in Mozilla, there is a mix of both variants, so it's impossible to choose one. I think that disabling this warning is best we can do.
Attachment #667883 - Flags: review?(mh+mozilla)
Attached patch fix v1.1Splinter Review
I previously attached wrong version.
Attachment #667883 - Attachment is obsolete: true
Attachment #667883 - Flags: review?(mh+mozilla)
Attachment #667885 - Flags: review?(mh+mozilla)
Attachment #667885 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/524f4ba45300
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Blocks: 802343
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.