797801 - [b2g-bluetooth] Cannot receive agent events after crash

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

When our process crashed and reboot, no AdapterAdded signal will be received after then. As a result, tasks in PrepareAdapterTask like register agents and add reserve service uuid cannot be executed properly.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: v1 patch

Check whether default adapter path is available when we enable bluetooth. If it isn't ready, wait for signal AdapterAdded from dbus. Otherwise, we can do PrepareAdapterTask right away.

Well , this bug is kind of an error-handling since it should be an ab-normal situation.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 667897 [details] [diff] [review]
v1 patch

Review of attachment 667897 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits picked

::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +1318,5 @@
>  
>  nsresult
> +GetDefaultAdapterPath(BluetoothValue& aValue, nsString& aError)
> +{
> +  DBusError err;

Nit: Needs a thread assert, since it blocks.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final version, r=qdot

try server: 
https://tbpl.mozilla.org/?tree=Try&rev=422356fe2072
https://tbpl.mozilla.org/?tree=Try&rev=de429113d36f

Comment 4

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8522ac2affa

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c8522ac2affa