Closed Bug 797801 Opened 8 years ago Closed 8 years ago

[b2g-bluetooth] Cannot receive agent events after crash

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: gyeh, Assigned: gyeh)

Details

Attachments

(1 file, 1 obsolete file)

When our process crashed and reboot, no AdapterAdded signal will be received after then. As a result, tasks in PrepareAdapterTask like register agents and add reserve service uuid cannot be executed properly.
Attached patch v1 patch (obsolete) — Splinter Review
Check whether default adapter path is available when we enable bluetooth. If it isn't ready, wait for signal AdapterAdded from dbus. Otherwise, we can do PrepareAdapterTask right away.

Well , this bug is kind of an error-handling since it should be an ab-normal situation.
Attachment #667897 - Flags: review?(kyle)
Comment on attachment 667897 [details] [diff] [review]
v1 patch

Review of attachment 667897 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits picked

::: dom/bluetooth/linux/BluetoothDBusService.cpp
@@ +1318,5 @@
>  
>  nsresult
> +GetDefaultAdapterPath(BluetoothValue& aValue, nsString& aError)
> +{
> +  DBusError err;

Nit: Needs a thread assert, since it blocks.
Attachment #667897 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/c8522ac2affa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.