797810 - [b2g-bluetooth] No reaction when a Headset device press button

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

After connecting to a headset device, when we press its button, we'll receive "A T + C K P D = 2 0 0" but no reaction on our phone.

The response should be depend on current call state. When we're dialing a phone call, it means hanging up the phone call. When there's a incoming phone call, it means answering it up. When there's no phone call for the time being, we probably just to redial the last number.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch(v1) - Support command "AT+CKPD=200" in BluetoothHfpManager

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 668295 [details] [diff] [review]
Patch(v1) - Support command "AT+CKPD=200" in BluetoothHfpManager

Review of attachment 668295 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/BluetoothHfpManager.cpp
@@ +485,5 @@
>    }
>    mDevicePath = aDeviceObjectPath;
>  
> +  nsString serviceUuidStr;
> +  if (aIsHandsfree)

Nit: Needs brackets.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 2(v1) - Cleanup for profile connect function

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 668296 [details] [diff] [review]
Patch 2(v1) - Cleanup for profile connect function

Review of attachment 668296 [details] [diff] [review]:
-----------------------------------------------------------------

Aweosme, much cleaner :D

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1 - Support command "AT+CKPD=200" in BluetoothHfpManager, r=qdot

Comment 6

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(Final version) - Support command "AT+CKPD=200" in BluetoothHfpManager, r=qdot

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 2(Final version) - Cleanup for profile connect function, r=qdot

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

try server:

https://tbpl.mozilla.org/?tree=Try&rev=b4ded695e4cb
https://tbpl.mozilla.org/?tree=Try&rev=3749c362eb6e

Comment 9

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6f9c9288080
https://hg.mozilla.org/integration/mozilla-inbound/rev/1761cc4fbb37

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f6f9c9288080
https://hg.mozilla.org/mozilla-central/rev/1761cc4fbb37