797904 - Include the app name in the memory reports dump

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Justin Lebar (not reading bugmail)]

Patch in a moment.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1

Comment 2

[Justin Lebar (not reading bugmail)]

Before you ask:

> +    mozilla::ipc::SetThisProcessName(NS_LossyConvertUTF16toASCII(aName).get());

I fully-qualified the function name here not because it needs to be disambiguated for the compiler (it's ContentChild::SetProcessName versus mozilla::ipc::SetThisProcessName) but because I wanted to disambiguate for humans.

Comment 3

[Justin Lebar (not reading bugmail)]

Comment on attachment 668023 [details] [diff] [review]
Patch, v1

Actually, slight improvement coming to the nsMemoryReporterManager bits.

Comment 4

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v2

This explicitly calls out the main process, which v1 didn't do.  No changes compared to v1 to anything other than nsMemoryReporterManager.cpp.

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 668062 [details] [diff] [review]
Patch, v2

Review of attachment 668062 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable, but I'm having trouble imagining how this affects the output.  It looks like on desktop nothing will change, is that right?  What difference does it make on B2G?

Comment 6

[Justin Lebar (not reading bugmail)]

(In reply to Nicholas Nethercote [:njn] from comment #5)
> Seems reasonable, but I'm having trouble imagining how this affects the
> output.  It looks like on desktop nothing will change, is that right?

Right.

> What difference does it make on B2G?

Instead of "Process ($PID)", we now say "Home Screen ($PID)" or "Calculator ($PID)".  This matches the output in b2g-procrank, which is a tool we have which annotates the output of procrank to show the app name.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6c86cf8e2478