Closed Bug 797913 Opened 7 years ago Closed 7 years ago

ok() and is() seems to be broken

Categories

(Testing :: Marionette, defect)

x86
All
defect
Not set

Tracking

(firefox19 fixed, firefox20 fixed, b2g18 fixed)

RESOLVED FIXED
mozilla20
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: mdas, Assigned: jgriffin)

Details

Attachments

(1 file)

a passing ok() or is(), the data reported is wrong: ok(true, "its true"); will report TEST-PASS true = false!

Reported by ddhal.
Currently, for the test:

ok(2 == 2, "test for ok()");

we output:

I/Gecko   (  109): MARIONETTE TEST RESULT:TEST-PASS | test_simpletest_pass.js | test for ok() - true was false, expected true

The "true was false, expected" true string is the "reason", which we should really only supply on failure for ok().
Actually, this is an easier fix, the above now shows this output:

I/Gecko   (  110): MARIONETTE TEST RESULT:TEST-PASS | test_simpletest_pass.js | test for ok() - true was true, expected true
Attachment #697287 - Flags: review?(mdas)
Attachment #697287 - Flags: review?(mdas) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/86d4e7126086
Assignee: nobody → jgriffin
Whiteboard: [automation-needed-in-aurora][automation-needed-in-b2g18]
Target Milestone: --- → mozilla20
https://hg.mozilla.org/mozilla-central/rev/86d4e7126086
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.