797913 - ok() and is() seems to be broken

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

a passing ok() or is(), the data reported is wrong: ok(true, "its true"); will report TEST-PASS true = false!

Reported by ddhal.

Comment 1

[Jonathan Griffin (:jgriffin)]

Currently, for the test:

ok(2 == 2, "test for ok()");

we output:

I/Gecko   (  109): MARIONETTE TEST RESULT:TEST-PASS | test_simpletest_pass.js | test for ok() - true was false, expected true

The "true was false, expected" true string is the "reason", which we should really only supply on failure for ok().

Comment 2

[Jonathan Griffin (:jgriffin)]

Attachment: Make is() output use actual result,

Actually, this is an easier fix, the above now shows this output:

I/Gecko   (  110): MARIONETTE TEST RESULT:TEST-PASS | test_simpletest_pass.js | test for ok() - true was true, expected true

Comment 3

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86d4e7126086

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/86d4e7126086

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f757cf6d96c3
https://hg.mozilla.org/releases/mozilla-b2g18/rev/3cabc9959cb9