797926 - Configure the Marketplace dev server as an allowed payment provider

Status: RESOLVED DUPLICATE of bug 824841

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kumar McMillan [:kumar]]

Once we have a dev server (bug 797917) we need to whitelist that URL so JWTs can be accepted on the phone for QA and functional testing. The patch would be similar to https://github.com/mozilla-b2g/gaia/commit/21cf147e78948e4ac562d39fa410a2c4371d5fb2

Comment 1

[Kumar McMillan [:kumar]]

(In reply to Kumar McMillan [:kumar] from comment #0)
> Once we have a dev server (bug 797917)

I meant that this depends on bug 797608 for the new dev server URL

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

We should probably also need to remove the mock provider prefs

Comment 3

[Kumar McMillan [:kumar]]

The new server is up and running (doesn't do much yet). I think the new prefs will look like this:

pref("dom.payment.provider.1.name", "firefoxmarketdev");
pref("dom.payment.provider.1.description", "Firefox Marketplace Dev");
pref("dom.payment.provider.1.type", "mozilla/payments/pay/v1");
pref("dom.payment.provider.1.uri", "https://marketplace-dev.allizom.org/mozpay/?req=");
pref("dom.payment.provider.1.requestMethod", "GET");

Comment 4

[Jason Smith [:jsmith]]

(In reply to Kumar McMillan [:kumar] from comment #3)
> The new server is up and running (doesn't do much yet). I think the new
> prefs will look like this:
> 
> pref("dom.payment.provider.1.name", "firefoxmarketdev");
> pref("dom.payment.provider.1.description", "Firefox Marketplace Dev");
> pref("dom.payment.provider.1.type", "mozilla/payments/pay/v1");
> pref("dom.payment.provider.1.uri",
> "https://marketplace-dev.allizom.org/mozpay/?req=");
> pref("dom.payment.provider.1.requestMethod", "GET");

You need me to validate this? I can modify my profile quickly and get some JWTs up against the marketplace dev payment provider if need be.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

This is needed to use the Marketplace payment provider from the device, so it makes sense to set it as blocking-basecamp+

Comment 6

[Jason Smith [:jsmith]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #5)
> This is needed to use the Marketplace payment provider from the device, so
> it makes sense to set it as blocking-basecamp+

Ehh...I don't think this blocks actually for the dev server specifically. Technically QA is not blocked if this isn't implemented, since I could modify the Gaia profile directly through adb to point to the dev server. The marketplace prod server version of this bug is definitely a blocker though.

It's nice to have this though.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Jason Smith [:jsmith] from comment #6)
> (In reply to Fernando Jiménez Moreno [:ferjm] from comment #5)
> > This is needed to use the Marketplace payment provider from the device, so
> > it makes sense to set it as blocking-basecamp+
> 
> Ehh...I don't think this blocks actually for the dev server specifically.
> Technically QA is not blocked if this isn't implemented, since I could
> modify the Gaia profile directly through adb to point to the dev server. The
> marketplace prod server version of this bug is definitely a blocker though.
> 
> It's nice to have this though.

Ok, sorry. I was thinking about the production server details.

Comment 8

[Kumar McMillan [:kumar]]

(In reply to Jason Smith [:jsmith] from comment #4)
> > pref("dom.payment.provider.1.name", "firefoxmarketdev");
> > pref("dom.payment.provider.1.description", "Firefox Marketplace Dev");
> > pref("dom.payment.provider.1.type", "mozilla/payments/pay/v1");
> > pref("dom.payment.provider.1.uri",
> > "https://marketplace-dev.allizom.org/mozpay/?req=");
> > pref("dom.payment.provider.1.requestMethod", "GET");
> 
> You need me to validate this? I can modify my profile quickly and get some
> JWTs up against the marketplace dev payment provider if need be.

Yeah, that would be helpful. Is there a way for me to edit the profile using a nightly otoro build? https://releases.mozilla.com/b2g/latest/ All I see is system.img but not a way to edit /system/b2g/defaults/pref/user.js before flashing.

Comment 9

[Jason Smith [:jsmith]]

(In reply to Kumar McMillan [:kumar] from comment #8)
> (In reply to Jason Smith [:jsmith] from comment #4)
> > > pref("dom.payment.provider.1.name", "firefoxmarketdev");
> > > pref("dom.payment.provider.1.description", "Firefox Marketplace Dev");
> > > pref("dom.payment.provider.1.type", "mozilla/payments/pay/v1");
> > > pref("dom.payment.provider.1.uri",
> > > "https://marketplace-dev.allizom.org/mozpay/?req=");
> > > pref("dom.payment.provider.1.requestMethod", "GET");
> > 
> > You need me to validate this? I can modify my profile quickly and get some
> > JWTs up against the marketplace dev payment provider if need be.
> 
> Yeah, that would be helpful. Is there a way for me to edit the profile using
> a nightly otoro build? https://releases.mozilla.com/b2g/latest/ All I see is
> system.img but not a way to edit /system/b2g/defaults/pref/user.js before
> flashing.

Yup. See the example script ferjm wrote in http://openwebdevice.com/blueviacerts/modifyCertDb.zip with the custom_pref.js. To get you unblocked, you could modify the custom_prefs.js file here to use the preferences you specified above and run the script with the phone plugged into your device. If you want a simplified script with adb to do this, look at the source of the script in there and reduce it down to the adb commands that add the custom_prefs.js piece to the Gaia profile. ferjm can add more details here if need be.

Comment 10

[Kumar McMillan [:kumar]]

bug 824841 is better because it has all necessary prefs, not just dev